Issue 1511773002: Revert "Merge to master: Take Jun's UTF16LE patches."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1511773002: Revert "Merge to master: Take Jun's UTF16LE patches." (Closed)

Created:
5 years ago by Oliver Chang

Modified:
5 years ago

Reviewers:
Lei Zhang, Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Merge to master: Take Jun's UTF16LE patches." Broke chrome bindings. This reverts commit c3e4ae5fe5067723b58a2029a95c6411c92bed15. R=thestig@chromium.org, tsepez@chromium.org BUG=567485 Committed: https://pdfium.googlesource.com/pdfium/+/8e7ed1a7759eb067063e3a52cf9efa80b8fc629b

Created: 5 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+48 lines, -43 lines)			Patch
M	core/src/fxcrt/fx_basic_wstring.cpp	View	1 chunk	+8 lines, -6 lines	0 comments	Download
M	core/src/fxcrt/fx_basic_wstring_unittest.cpp	View	1 chunk	+6 lines, -6 lines	0 comments	Download
M	fpdfsdk/src/fpdfdoc_embeddertest.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	fpdfsdk/src/fpdftext_embeddertest.cpp	View	4 chunks	+22 lines, -19 lines	0 comments	Download
M	fpdfsdk/src/fpdfview_embeddertest.cpp	View	5 chunks	+10 lines, -10 lines	0 comments	Download

Total messages: 5 (1 generated)

Oliver Chang

5 years ago (2015-12-09 00:12:29 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
8e7ed1a7759eb067063e3a52cf9efa80b8fc629b (presubmit successful).