Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(5)

Issue 1511773002: Revert "Merge to master: Take Jun's UTF16LE patches." (Closed)

Created:
4 years, 12 months ago by Oliver Chang
Modified:
4 years, 12 months ago
Reviewers:
Lei Zhang, Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Merge to master: Take Jun's UTF16LE patches." Broke chrome bindings. This reverts commit c3e4ae5fe5067723b58a2029a95c6411c92bed15. R=thestig@chromium.org, tsepez@chromium.org BUG=567485 Committed: https://pdfium.googlesource.com/pdfium/+/8e7ed1a7759eb067063e3a52cf9efa80b8fc629b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -43 lines) Patch
M core/src/fxcrt/fx_basic_wstring.cpp View 1 chunk +8 lines, -6 lines 0 comments Download
M core/src/fxcrt/fx_basic_wstring_unittest.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M fpdfsdk/src/fpdfdoc_embeddertest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/fpdftext_embeddertest.cpp View 4 chunks +22 lines, -19 lines 0 comments Download
M fpdfsdk/src/fpdfview_embeddertest.cpp View 5 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Oliver Chang
ptal.
4 years, 12 months ago (2015-12-08 23:53:14 UTC) #1
Lei Zhang
lgtm Let's do this for now to unblock the Chromium DEPS roll.
4 years, 12 months ago (2015-12-09 00:01:19 UTC) #2
Tom Sepez
lgtm
4 years, 12 months ago (2015-12-09 00:01:23 UTC) #3
Oliver Chang
4 years, 12 months ago (2015-12-09 00:12:29 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8e7ed1a7759eb067063e3a52cf9efa80b8fc629b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698