Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 1511753004: Add an explicit dependency on device_serial_mojo to battor agent. (Closed)

Created:
5 years ago by Anand Mistry (off Chromium)
Modified:
5 years ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add an explicit dependency on device_serial_mojo to battor agent. BUG=564667 Committed: https://crrev.com/2618c43bb03317d92b42cba18917b68168ab0d4e Cr-Commit-Position: refs/heads/master@{#364457}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M tools/battor_agent/battor_agent.gyp View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Anand Mistry (off Chromium)
Fixes the underspecified dep: amistry@amistry-z620-l:~/chrome-source/src$ ninja -C out/Release -t query obj/tools/battor_agent/battor_agent_lib.battor_agent.o obj/tools/battor_agent/battor_agent_lib.battor_agent.o: input: cxx ../../tools/battor_agent/battor_agent.cc ...
5 years ago (2015-12-10 07:28:09 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1511753004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1511753004/1
5 years ago (2015-12-10 07:28:54 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-10 07:39:32 UTC) #6
nednguyen
lgtm
5 years ago (2015-12-10 16:32:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1511753004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1511753004/1
5 years ago (2015-12-10 20:13:01 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-10 20:23:59 UTC) #11
commit-bot: I haz the power
5 years ago (2015-12-10 20:24:57 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2618c43bb03317d92b42cba18917b68168ab0d4e
Cr-Commit-Position: refs/heads/master@{#364457}

Powered by Google App Engine
This is Rietveld 408576698