Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(905)

Issue 1511743004: cc: Fix recording of GPU rasterization histogram for renderer compositor. (Closed)

Created:
5 years ago by Khushal
Modified:
5 years ago
Reviewers:
vmpstr
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Fix recording of GPU rasterization histogram for renderer compositor. The recording was disabled in https://codereview.chromium.org/1464313007/ CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/b54107d0f0360a1f9bd5e3664b90b3662da9e153 Cr-Commit-Position: refs/heads/master@{#364456}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add test. #

Patch Set 3 : Add ForTesting to SetTaskRunnerProvider. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -8 lines) Patch
M cc/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M cc/cc_tests.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M cc/layers/scrollbar_layer_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/test/fake_layer_tree_host.h View 1 3 chunks +9 lines, -1 line 0 comments Download
M cc/test/fake_layer_tree_host.cc View 1 2 3 chunks +18 lines, -3 lines 0 comments Download
M cc/trees/layer_tree_host.h View 1 2 4 chunks +8 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host.cc View 1 2 2 chunks +8 lines, -2 lines 0 comments Download
A cc/trees/layer_tree_host_unittest_record_gpu_histogram.cc View 1 1 chunk +37 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Khushal
5 years ago (2015-12-10 00:27:31 UTC) #4
vmpstr
https://codereview.chromium.org/1511743004/diff/1/cc/trees/layer_tree_host.cc File cc/trees/layer_tree_host.cc (right): https://codereview.chromium.org/1511743004/diff/1/cc/trees/layer_tree_host.cc#newcode741 cc/trees/layer_tree_host.cc:741: if (gpu_rasterization_histogram_recorded_ || IsSingleThreaded()) It would be nice to ...
5 years ago (2015-12-10 00:35:00 UTC) #5
Khushal
On 2015/12/10 00:35:00, vmpstr wrote: > https://codereview.chromium.org/1511743004/diff/1/cc/trees/layer_tree_host.cc > File cc/trees/layer_tree_host.cc (right): > > https://codereview.chromium.org/1511743004/diff/1/cc/trees/layer_tree_host.cc#newcode741 > ...
5 years ago (2015-12-10 01:59:41 UTC) #6
vmpstr
lgtm, thanks for the test!
5 years ago (2015-12-10 18:58:12 UTC) #7
Khushal
On 2015/12/10 18:58:12, vmpstr wrote: > lgtm, thanks for the test! No problem. Sorry about ...
5 years ago (2015-12-10 19:01:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1511743004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1511743004/40001
5 years ago (2015-12-10 19:04:32 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-12-10 20:21:03 UTC) #12
commit-bot: I haz the power
5 years ago (2015-12-10 20:22:57 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b54107d0f0360a1f9bd5e3664b90b3662da9e153
Cr-Commit-Position: refs/heads/master@{#364456}

Powered by Google App Engine
This is Rietveld 408576698