Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: src/IceAssemblerX86BaseImpl.h

Issue 1511653002: Fix problems with sandboxing and the ARM integrated assembler. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Fix nit. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/IceAssemblerX86Base.h ('k') | src/IceInstARM32.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceAssemblerX86BaseImpl.h
diff --git a/src/IceAssemblerX86BaseImpl.h b/src/IceAssemblerX86BaseImpl.h
index f48529aca8df95e16e09d97c0104df2871c68769..9fd1de53e0154c7a5009015d6399082e8b83cc66 100644
--- a/src/IceAssemblerX86BaseImpl.h
+++ b/src/IceAssemblerX86BaseImpl.h
@@ -3404,17 +3404,15 @@ void AssemblerX86Base<Machine>::emitLabelLink(Label *Label) {
assert(!Label->isBound());
intptr_t Position = Buffer.size();
emitInt32(Label->Position);
- if (!getPreliminary())
- Label->linkTo(Position);
+ Label->linkTo(*this, Position);
}
template <class Machine>
-void AssemblerX86Base<Machine>::emitNearLabelLink(Label *label) {
- assert(!label->isBound());
- intptr_t position = Buffer.size();
+void AssemblerX86Base<Machine>::emitNearLabelLink(Label *Label) {
+ assert(!Label->isBound());
+ intptr_t Position = Buffer.size();
emitUint8(0);
- if (!getPreliminary())
- label->nearLinkTo(position);
+ Label->nearLinkTo(*this, Position);
}
template <class Machine>
« no previous file with comments | « src/IceAssemblerX86Base.h ('k') | src/IceInstARM32.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698