Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: src/IceAssemblerARM32.h

Issue 1511653002: Fix problems with sandboxing and the ARM integrated assembler. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Clean up small issues raised in last patch. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/IceAssemblerARM32.h
diff --git a/src/IceAssemblerARM32.h b/src/IceAssemblerARM32.h
index 171d524acc55a350ef418d3b89a731c5f87dff6d..461ab0f40e3ce95048af77f32116d4f3af29ef12 100644
--- a/src/IceAssemblerARM32.h
+++ b/src/IceAssemblerARM32.h
@@ -135,10 +135,7 @@ public:
return llvm::ArrayRef<uint8_t>(Padding, 4);
}
- void padWithNop(intptr_t Padding) override {
- (void)Padding;
- llvm_unreachable("Not yet implemented.");
- }
+ void padWithNop(intptr_t Padding) override;
Ice::Label *getCfgNodeLabel(SizeT NodeNumber) override {
assert(NodeNumber < CfgNodeLabels.size());
@@ -242,6 +239,8 @@ public:
void mvn(const Operand *OpRd, const Operand *OpScc, CondARM32::Cond Cond);
+ void nop();
+
void orr(const Operand *OpRd, const Operand *OpRn, const Operand *OpSrc1,
bool SetFlags, CondARM32::Cond Cond);
« src/IceAssembler.cpp ('K') | « src/IceAssembler.cpp ('k') | src/IceAssemblerARM32.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698