src/DartARM32/assembler_arm.h - Issue 1511653002: Fix problems with sandboxing and the ARM integrated assembler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/DartARM32/assembler_arm.h

Issue 1511653002: Fix problems with sandboxing and the ARM integrated assembler. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Lift pass information into linkTo() and nearLinkTo(). Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/DartARM32/assembler_arm.h

diff --git a/src/DartARM32/assembler_arm.h b/src/DartARM32/assembler_arm.h

index fe7418f7ab2bd5a48a3851394b35f01e1a9114c4..77dac05e3f44c04c11e7cf2cd056f0adc2830a49 100644

--- a/src/DartARM32/assembler_arm.h

+++ b/src/DartARM32/assembler_arm.h

@@ -595,9 +595,10 @@ class Assembler : public ValueObject {

// Miscellaneous instructions.

void clrex();

+#if 0

+ // Moved to ARM32::AssemblerARM32::nop().

void nop(Condition cond = AL);

-#if 0

// Moved to ARM32::AssemblerARM32::bkpt()

// Note that gdb sets breakpoints using the undefined instruction 0xe7f001f0.

void bkpt(uint16_t imm16);

« no previous file with comments | « no previous file | src/DartARM32/assembler_arm.cc » ('j') | src/IceAssembler.h » ('J')