| Index: src/a64/stub-cache-a64.cc
|
| diff --git a/src/a64/stub-cache-a64.cc b/src/a64/stub-cache-a64.cc
|
| index 2cdc1b97fc5da7760111ece4f55a041e8907f54d..a81b3f8a316e8fcc5c79be19fd100999a7590a2b 100644
|
| --- a/src/a64/stub-cache-a64.cc
|
| +++ b/src/a64/stub-cache-a64.cc
|
| @@ -921,8 +921,8 @@ static void GenerateFastApiDirectCall(MacroAssembler* masm,
|
| const int kStackUnwindSpace = argc + kFastApiCallArguments + 1;
|
|
|
| Address function_address = v8::ToCData<Address>(api_call_info->callback());
|
| - bool returns_handle =
|
| - !CallbackTable::ReturnsVoid(masm->isolate(), function_address);
|
| + // TODO(dcarney): fix signatures using returns_handle
|
| + const bool returns_handle = false;
|
| ApiFunction fun(function_address);
|
| ExternalReference::Type type =
|
| returns_handle ?
|
| @@ -930,10 +930,7 @@ static void GenerateFastApiDirectCall(MacroAssembler* masm,
|
| ExternalReference::DIRECT_API_CALL_NEW;
|
| ExternalReference ref = ExternalReference(&fun, type, masm->isolate());
|
|
|
| - Address thunk_address =
|
| - returns_handle ?
|
| - FUNCTION_ADDR(&InvokeInvocationCallback) :
|
| - FUNCTION_ADDR(&InvokeFunctionCallback);
|
| + Address thunk_address = FUNCTION_ADDR(&InvokeFunctionCallback);
|
| ExternalReference::Type thunk_type =
|
| returns_handle ?
|
| ExternalReference::PROFILING_API_CALL :
|
| @@ -1455,7 +1452,8 @@ void BaseLoadStubCompiler::GenerateLoadCallback(
|
|
|
| // Do the API call.
|
| Address getter_address = v8::ToCData<Address>(callback->getter());
|
| - bool returns_handle = !CallbackTable::ReturnsVoid(isolate(), getter_address);
|
| + // TODO(dcarney): fix signatures using returns_handle
|
| + const bool returns_handle = false;
|
|
|
| ApiFunction fun(getter_address);
|
| ExternalReference::Type type =
|
| @@ -1464,13 +1462,9 @@ void BaseLoadStubCompiler::GenerateLoadCallback(
|
| ExternalReference::DIRECT_GETTER_CALL_NEW;
|
| ExternalReference ref = ExternalReference(&fun, type, isolate());
|
|
|
| - Address thunk_address = returns_handle
|
| - ? FUNCTION_ADDR(&InvokeAccessorGetter)
|
| - : FUNCTION_ADDR(&InvokeAccessorGetterCallback);
|
| + Address thunk_address = FUNCTION_ADDR(&InvokeAccessorGetterCallback);
|
| ExternalReference::Type thunk_type =
|
| - returns_handle ?
|
| - ExternalReference::PROFILING_GETTER_CALL :
|
| - ExternalReference::PROFILING_GETTER_CALL_NEW;
|
| + ExternalReference::PROFILING_GETTER_CALL_NEW;
|
| ApiFunction thunk_fun(thunk_address);
|
| ExternalReference thunk_ref =
|
| ExternalReference(&thunk_fun, thunk_type, isolate());
|
|
|