Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 151163004: net: pin (*.)googletagmanager.com (Closed)

Created:
6 years, 10 months ago by agl
Modified:
6 years, 10 months ago
Reviewers:
palmer
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : uploading again after revert. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M net/http/transport_security_state.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M net/http/transport_security_state_static.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/http/transport_security_state_static.json View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
agl
6 years, 10 months ago (2014-02-03 15:25:19 UTC) #1
agl
Committed patchset #1 manually as r248500.
6 years, 10 months ago (2014-02-03 16:14:00 UTC) #2
agl
Got my branches mixed up and didn't mean to land this. Have reverted. Please still ...
6 years, 10 months ago (2014-02-03 16:24:55 UTC) #3
palmer
LGTM
6 years, 10 months ago (2014-02-03 18:29:01 UTC) #4
agl
The CQ bit was checked by agl@chromium.org
6 years, 10 months ago (2014-02-03 19:00:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/agl@chromium.org/151163004/70001
6 years, 10 months ago (2014-02-03 19:04:03 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-03 19:21:12 UTC) #7
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=47696
6 years, 10 months ago (2014-02-03 19:21:13 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 19:21:18 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 19:21:22 UTC) #10
agl
6 years, 10 months ago (2014-02-04 15:20:29 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 manually as r248721 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698