Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 151163003: Revert of Enable icu_use_data_file_flag on CrOS (Closed)

Created:
6 years, 10 months ago by Cait (Slow)
Modified:
6 years, 10 months ago
CC:
chromium-reviews, jshin+watch_chromium.org
Visibility:
Public.

Description

Revert of Enable icu_use_data_file_flag on CrOS (https://codereview.chromium.org/135963010/) Reason for revert: This is breaking the Chrome OS bots on the waterfall: http://build.chromium.org/p/chromium.chromiumos/buildstatus?builder=ChromiumOS%20%28x86%29&number=19593 http://build.chromium.org/p/chromium.chromiumos/buildstatus?builder=ChromiumOS%20%28amd64%29&number=13965 From discussion on chromium-dev: Looking at /var/log/messages for one of the failing tests, Chrome is exiting with SIGABRT over and over, and ui.LATEST has the following over and over: [0201/085858:FATAL:content_main_runner.cc(735)] Check failed: base::i18n::InitializeICU(). Original issue's description: > Enable icu_use_data_file_flag on CrOS > > 1. Enable icu_use_data_file_flag on CrOS > > 2. Doing #1 led to a crash because GetStringUTF8 (that relies on ICU to determine whether the current UI language is RTL) is called before InitializeICU is called. Instead of using GetStringUTF8, get the string directly from the resource bundle because there's no need to adjust the string for the RTL locale in this particular case. > > Note to perf-sheriff : The size of chrome binary will be 10M smaller because the ICU data is now in a separate file (icudtl.dat) whose size is about 10M. > > BUG=72633 > TEST=ui_base_unittests > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248325 TBR=tony@chromium.org,vapier@chromium.org,mark@chromium.org,nkostylev@chromium.org,jshin@chromium.org NOTREECHECKS=true NOTRY=true BUG=72633 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248374

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M build/common.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/resource/resource_bundle.cc View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Cait (Slow)
Created Revert of Enable icu_use_data_file_flag on CrOS
6 years, 10 months ago (2014-02-02 04:10:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caitkp@chromium.org/151163003/1
6 years, 10 months ago (2014-02-02 04:10:59 UTC) #2
commit-bot: I haz the power
Change committed as 248374
6 years, 10 months ago (2014-02-02 04:11:15 UTC) #3
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-02 04:11:20 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-02-02 04:11:22 UTC) #5
Message was sent while issue was closed.
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698