DescriptionRevert of Enable icu_use_data_file_flag on CrOS (https://codereview.chromium.org/135963010/)
Reason for revert:
This is breaking the Chrome OS bots on the waterfall:
http://build.chromium.org/p/chromium.chromiumos/buildstatus?builder=ChromiumOS%20%28x86%29&number=19593
http://build.chromium.org/p/chromium.chromiumos/buildstatus?builder=ChromiumOS%20%28amd64%29&number=13965
From discussion on chromium-dev:
Looking at /var/log/messages for one of the failing tests, Chrome is exiting with SIGABRT over and over, and ui.LATEST has the following over and over:
[0201/085858:FATAL:content_main_runner.cc(735)] Check failed: base::i18n::InitializeICU().
Original issue's description:
> Enable icu_use_data_file_flag on CrOS
>
> 1. Enable icu_use_data_file_flag on CrOS
>
> 2. Doing #1 led to a crash because GetStringUTF8 (that relies on ICU to determine whether the current UI language is RTL) is called before InitializeICU is called. Instead of using GetStringUTF8, get the string directly from the resource bundle because there's no need to adjust the string for the RTL locale in this particular case.
>
> Note to perf-sheriff : The size of chrome binary will be 10M smaller because the ICU data is now in a separate file (icudtl.dat) whose size is about 10M.
>
> BUG=72633
> TEST=ui_base_unittests
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248325
TBR=tony@chromium.org,vapier@chromium.org,mark@chromium.org,nkostylev@chromium.org,jshin@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=72633
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248374
Patch Set 1 #
Created: 6 years, 10 months ago
(Patch set is too large to download)
Messages
Total messages: 5 (0 generated)
|