Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 1511603006: [Media Router] Update height of extensionview in route-details. (Closed)

Created:
5 years ago by apacible
Modified:
5 years ago
Reviewers:
imcheng
CC:
chromium-reviews, media-router+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Router] Update height of extensionview in route-details. Per conversation with UX, this change updates the height of the extensionview in route-details to 136px from 160px. The custom controls provided for the extensionview should be cropped/scaled to fit the extensionview from the provider side. BUG=567807 Committed: https://crrev.com/21e37370e980ddfec7640120a8466fc1fab71abb Cr-Commit-Position: refs/heads/master@{#364430}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/media_router/elements/route_details/route_details.css View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
apacible
PTAL, thanks! Before: https://screenshot.googleplex.com/nZJn0GgiGSH.png After: https://screenshot.googleplex.com/ndjhd2XFTwg.png
5 years ago (2015-12-10 01:41:48 UTC) #3
imcheng
lgtm
5 years ago (2015-12-10 18:33:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1511603006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1511603006/1
5 years ago (2015-12-10 18:54:54 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-10 19:42:18 UTC) #8
commit-bot: I haz the power
5 years ago (2015-12-10 19:43:11 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/21e37370e980ddfec7640120a8466fc1fab71abb
Cr-Commit-Position: refs/heads/master@{#364430}

Powered by Google App Engine
This is Rietveld 408576698