Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1511603003: Enable --trace-to-console in ChromeOS builds (Closed)

Created:
5 years ago by rjkroege
Modified:
5 years ago
Reviewers:
oshima
CC:
chromium-reviews, dzhioev+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable --trace-to-console in ChromeOS builds --trace-to-console was not being exported to new Chrome instances across restart requests and so tracing didn't work in signed-in sessions. Add it to the white list. Committed: https://crrev.com/832bcfaf04f0663200f896c52138af39f8f472ac Cr-Commit-Position: refs/heads/master@{#364162}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
rjkroege
Related to our earlier discussion about why I wasn't seeing output. Add tracing to the ...
5 years ago (2015-12-09 03:15:23 UTC) #2
oshima
lgtm
5 years ago (2015-12-09 19:41:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1511603003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1511603003/1
5 years ago (2015-12-09 19:46:22 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-09 21:42:58 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-09 21:43:50 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/832bcfaf04f0663200f896c52138af39f8f472ac
Cr-Commit-Position: refs/heads/master@{#364162}

Powered by Google App Engine
This is Rietveld 408576698