Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 1511553005: suggest yield and yeild* - fixes #24346 (Closed)

Created:
5 years ago by danrubel
Modified:
5 years ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : merge and cleanup imports #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -2 lines) Patch
M pkg/analysis_server/lib/src/services/completion/dart/keyword_contributor.dart View 1 4 chunks +13 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/keyword_contributor_test.dart View 4 chunks +63 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
danrubel
5 years ago (2015-12-09 14:31:36 UTC) #2
scheglov
LGTM
5 years ago (2015-12-09 16:22:44 UTC) #3
danrubel
5 years ago (2015-12-09 17:03:15 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
e9a77de7ddd4b8d098e92648fb5a7c1ba07e7019 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698