third_party/WebKit/Source/core/svg/SVGSVGElement.cpp - Issue 1511523002: Align HTMLImageElement relevant mutations to spec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGSVGElement.cpp

Issue 1511523002: Align HTMLImageElement relevant mutations to spec (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix removal issue when a text node is between <source> and <img> Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/svg/SVGSVGElement.cpp

diff --git a/third_party/WebKit/Source/core/svg/SVGSVGElement.cpp b/third_party/WebKit/Source/core/svg/SVGSVGElement.cpp

index 576fc4c7fe74849a2a946d918ac9f3950587d7ec..d9d7d399a792d96abd9bd8cab88cdb1f6c9b2871 100644

--- a/third_party/WebKit/Source/core/svg/SVGSVGElement.cpp

+++ b/third_party/WebKit/Source/core/svg/SVGSVGElement.cpp

@@ -548,7 +548,7 @@ Node::InsertionNotificationRequest SVGSVGElement::insertedInto(ContainerNode* ro

return SVGGraphicsElement::insertedInto(rootParent);

}

-void SVGSVGElement::removedFrom(ContainerNode* rootParent)

+void SVGSVGElement::removedFrom(ContainerNode* rootParent, Node* next)

{

if (rootParent->inDocument()) {

SVGDocumentExtensions& svgExtensions = document().accessSVGExtensions();

@@ -556,7 +556,7 @@ void SVGSVGElement::removedFrom(ContainerNode* rootParent)

svgExtensions.removeSVGRootWithRelativeLengthDescendents(this);

}

- SVGGraphicsElement::removedFrom(rootParent);

+ SVGGraphicsElement::removedFrom(rootParent, next);

}

void SVGSVGElement::pauseAnimations()