third_party/WebKit/Source/core/svg/SVGElement.cpp - Issue 1511523002: Align HTMLImageElement relevant mutations to spec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGElement.cpp

Issue 1511523002: Align HTMLImageElement relevant mutations to spec (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix removal issue when a text node is between <source> and <img> Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/svg/SVGElement.cpp

diff --git a/third_party/WebKit/Source/core/svg/SVGElement.cpp b/third_party/WebKit/Source/core/svg/SVGElement.cpp

index be63df4c5578d76e8fda05c3e553e27398f816c3..0aa7239f0420a5006aa9e89606d2765e93f5994f 100644

--- a/third_party/WebKit/Source/core/svg/SVGElement.cpp

+++ b/third_party/WebKit/Source/core/svg/SVGElement.cpp

@@ -290,7 +290,7 @@ Node::InsertionNotificationRequest SVGElement::insertedInto(ContainerNode* rootP

return InsertionDone;

}

-void SVGElement::removedFrom(ContainerNode* rootParent)

+void SVGElement::removedFrom(ContainerNode* rootParent, Node* next)

{

bool wasInDocument = rootParent->inDocument();

@@ -308,7 +308,7 @@ void SVGElement::removedFrom(ContainerNode* rootParent)

ASSERT_WITH_SECURITY_IMPLICATION(!rootParent->isSVGElement() || !toSVGElement(rootParent)->m_elementsWithRelativeLengths.contains(this));

- Element::removedFrom(rootParent);

+ Element::removedFrom(rootParent, next);

if (wasInDocument) {

rebuildAllIncomingReferences();