third_party/WebKit/Source/core/html/HTMLOptionElement.cpp - Issue 1511523002: Align HTMLImageElement relevant mutations to spec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLOptionElement.cpp

Issue 1511523002: Align HTMLImageElement relevant mutations to spec (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix removal issue when a text node is between <source> and <img> Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLOptionElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLOptionElement.cpp b/third_party/WebKit/Source/core/html/HTMLOptionElement.cpp

index 8594640e7522501ba53531aa0dab8101a2b95f5b..8e38035ddc55cdc732c785a48f05dfcacfd502b3 100644

--- a/third_party/WebKit/Source/core/html/HTMLOptionElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLOptionElement.cpp

@@ -387,7 +387,7 @@ Node::InsertionNotificationRequest HTMLOptionElement::insertedInto(ContainerNode

return InsertionDone;

}

-void HTMLOptionElement::removedFrom(ContainerNode* insertionPoint)

+void HTMLOptionElement::removedFrom(ContainerNode* insertionPoint, Node* next)

{

if (isHTMLSelectElement(*insertionPoint)) {

if (!parentNode() || isHTMLOptGroupElement(*parentNode()))

@@ -397,7 +397,7 @@ void HTMLOptionElement::removedFrom(ContainerNode* insertionPoint)

if (isHTMLSelectElement(parent))

toHTMLSelectElement(parent)->optionRemoved(*this);

}

- HTMLElement::removedFrom(insertionPoint);

+ HTMLElement::removedFrom(insertionPoint, next);

}

String HTMLOptionElement::collectOptionInnerText() const