third_party/WebKit/Source/core/html/HTMLInputElement.cpp - Issue 1511523002: Align HTMLImageElement relevant mutations to spec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLInputElement.cpp

Issue 1511523002: Align HTMLImageElement relevant mutations to spec (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix removal issue when a text node is between <source> and <img> Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLInputElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLInputElement.cpp b/third_party/WebKit/Source/core/html/HTMLInputElement.cpp

index b2ee9ac98748c35c7ae48ef41a8777ede5b7672c..23f1fb3bbede398f29bed91e55295dac170dd735 100644

--- a/third_party/WebKit/Source/core/html/HTMLInputElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLInputElement.cpp

@@ -1515,12 +1515,12 @@ Node::InsertionNotificationRequest HTMLInputElement::insertedInto(ContainerNode*

return InsertionShouldCallDidNotifySubtreeInsertions;

}

-void HTMLInputElement::removedFrom(ContainerNode* insertionPoint)

+void HTMLInputElement::removedFrom(ContainerNode* insertionPoint, Node* next)

{

m_inputTypeView->closePopupView();

if (insertionPoint->inDocument() && !form())

removeFromRadioButtonGroup();

- HTMLTextFormControlElement::removedFrom(insertionPoint);

+ HTMLTextFormControlElement::removedFrom(insertionPoint, next);

ASSERT(!inDocument());

resetListAttributeTargetObserver();

}