third_party/WebKit/Source/core/html/HTMLFormControlElementWithState.cpp - Issue 1511523002: Align HTMLImageElement relevant mutations to spec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLFormControlElementWithState.cpp

Issue 1511523002: Align HTMLImageElement relevant mutations to spec (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix removal issue when a text node is between <source> and <img> Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/dom/ContainerNode.cpp ('K') | « third_party/WebKit/Source/core/html/HTMLFormControlElementWithState.h ('k') | third_party/WebKit/Source/core/html/HTMLFormElement.h » ('j') | third_party/WebKit/Source/core/html/HTMLPictureElement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLFormControlElementWithState.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLFormControlElementWithState.cpp b/third_party/WebKit/Source/core/html/HTMLFormControlElementWithState.cpp

index 88c2036dd753fff77b4855e7a4dd13cef236dfca..f0fdf9193da0ee579dc77368129cfd69fd18bee7 100644

--- a/third_party/WebKit/Source/core/html/HTMLFormControlElementWithState.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLFormControlElementWithState.cpp

@@ -50,11 +50,11 @@ Node::InsertionNotificationRequest HTMLFormControlElementWithState::insertedInto

return HTMLFormControlElement::insertedInto(insertionPoint);

}

-void HTMLFormControlElementWithState::removedFrom(ContainerNode* insertionPoint)

+void HTMLFormControlElementWithState::removedFrom(ContainerNode* insertionPoint, Node* next)

{

if (insertionPoint->inDocument() && !containingShadowRoot() && !insertionPoint->containingShadowRoot())

document().formController().unregisterStatefulFormControl(*this);

- HTMLFormControlElement::removedFrom(insertionPoint);

+ HTMLFormControlElement::removedFrom(insertionPoint, next);

}

bool HTMLFormControlElementWithState::shouldAutocomplete() const