Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Side by Side Diff: third_party/WebKit/Source/core/svg/SVGFEImageElement.cpp

Issue 1511523002: Align HTMLImageElement relevant mutations to spec (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix removal issue when a text node is between <source> and <img> Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2007 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2007 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005 Rob Buis <buis@kde.org>
4 * Copyright (C) 2010 Dirk Schulze <krit@webkit.org> 4 * Copyright (C) 2010 Dirk Schulze <krit@webkit.org>
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 119 matching lines...) Expand 10 before | Expand all | Expand 10 after
130 SVGFilterPrimitiveStandardAttributes::svgAttributeChanged(attrName); 130 SVGFilterPrimitiveStandardAttributes::svgAttributeChanged(attrName);
131 } 131 }
132 132
133 Node::InsertionNotificationRequest SVGFEImageElement::insertedInto(ContainerNode * rootParent) 133 Node::InsertionNotificationRequest SVGFEImageElement::insertedInto(ContainerNode * rootParent)
134 { 134 {
135 SVGFilterPrimitiveStandardAttributes::insertedInto(rootParent); 135 SVGFilterPrimitiveStandardAttributes::insertedInto(rootParent);
136 buildPendingResource(); 136 buildPendingResource();
137 return InsertionDone; 137 return InsertionDone;
138 } 138 }
139 139
140 void SVGFEImageElement::removedFrom(ContainerNode* rootParent) 140 void SVGFEImageElement::removedFrom(ContainerNode* rootParent, Node* next)
141 { 141 {
142 SVGFilterPrimitiveStandardAttributes::removedFrom(rootParent); 142 SVGFilterPrimitiveStandardAttributes::removedFrom(rootParent, next);
143 if (rootParent->inDocument()) 143 if (rootParent->inDocument())
144 clearResourceReferences(); 144 clearResourceReferences();
145 } 145 }
146 146
147 void SVGFEImageElement::notifyFinished(Resource*) 147 void SVGFEImageElement::notifyFinished(Resource*)
148 { 148 {
149 if (!inDocument()) 149 if (!inDocument())
150 return; 150 return;
151 151
152 Element* parent = parentElement(); 152 Element* parent = parentElement();
(...skipping 10 matching lines...) Expand all
163 // Don't use the broken image icon on image loading errors. 163 // Don't use the broken image icon on image loading errors.
164 RefPtr<Image> image = m_cachedImage->errorOccurred() ? 164 RefPtr<Image> image = m_cachedImage->errorOccurred() ?
165 nullptr : m_cachedImage->image(); 165 nullptr : m_cachedImage->image();
166 return FEImage::createWithImage(filter, image, m_preserveAspectRatio->cu rrentValue()); 166 return FEImage::createWithImage(filter, image, m_preserveAspectRatio->cu rrentValue());
167 } 167 }
168 168
169 return FEImage::createWithIRIReference(filter, treeScope(), hrefString(), m_ preserveAspectRatio->currentValue()); 169 return FEImage::createWithIRIReference(filter, treeScope(), hrefString(), m_ preserveAspectRatio->currentValue());
170 } 170 }
171 171
172 } 172 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698