Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp

Issue 1511523002: Align HTMLImageElement relevant mutations to spec (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix removal issue when a text node is between <source> and <img> Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /** 1 /**
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Stefan Schimanski (1Stein@gmx.de) 4 * (C) 2000 Stefan Schimanski (1Stein@gmx.de)
5 * Copyright (C) 2004, 2005, 2006 Apple Computer, Inc. 5 * Copyright (C) 2004, 2005, 2006 Apple Computer, Inc.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 205 matching lines...) Expand 10 before | Expand all | Expand 10 after
216 void HTMLPlugInElement::updateWidget() 216 void HTMLPlugInElement::updateWidget()
217 { 217 {
218 RefPtrWillBeRawPtr<HTMLPlugInElement> protector(this); 218 RefPtrWillBeRawPtr<HTMLPlugInElement> protector(this);
219 updateWidgetInternal(); 219 updateWidgetInternal();
220 if (m_isDelayingLoadEvent) { 220 if (m_isDelayingLoadEvent) {
221 m_isDelayingLoadEvent = false; 221 m_isDelayingLoadEvent = false;
222 document().decrementLoadEventDelayCount(); 222 document().decrementLoadEventDelayCount();
223 } 223 }
224 } 224 }
225 225
226 void HTMLPlugInElement::removedFrom(ContainerNode* insertionPoint) 226 void HTMLPlugInElement::removedFrom(ContainerNode* insertionPoint, Node* next)
227 { 227 {
228 // If we've persisted the plugin and we're removed from the tree then 228 // If we've persisted the plugin and we're removed from the tree then
229 // make sure we cleanup the persistance pointer. 229 // make sure we cleanup the persistance pointer.
230 if (m_persistedPluginWidget) { 230 if (m_persistedPluginWidget) {
231 HTMLFrameOwnerElement::UpdateSuspendScope suspendWidgetHierarchyUpdates; 231 HTMLFrameOwnerElement::UpdateSuspendScope suspendWidgetHierarchyUpdates;
232 setPersistedPluginWidget(nullptr); 232 setPersistedPluginWidget(nullptr);
233 } 233 }
234 HTMLFrameOwnerElement::removedFrom(insertionPoint); 234 HTMLFrameOwnerElement::removedFrom(insertionPoint, next);
235 } 235 }
236 236
237 void HTMLPlugInElement::requestPluginCreationWithoutLayoutObjectIfPossible() 237 void HTMLPlugInElement::requestPluginCreationWithoutLayoutObjectIfPossible()
238 { 238 {
239 if (m_serviceType.isEmpty()) 239 if (m_serviceType.isEmpty())
240 return; 240 return;
241 241
242 if (!document().frame() 242 if (!document().frame()
243 || !document().frame()->loader().client()->canCreatePluginWithoutRendere r(m_serviceType)) 243 || !document().frame()->loader().client()->canCreatePluginWithoutRendere r(m_serviceType))
244 return; 244 return;
(...skipping 418 matching lines...) Expand 10 before | Expand all | Expand 10 after
663 return openShadowRoot(); 663 return openShadowRoot();
664 } 664 }
665 665
666 void HTMLPlugInElement::lazyReattachIfNeeded() 666 void HTMLPlugInElement::lazyReattachIfNeeded()
667 { 667 {
668 if (!useFallbackContent() && needsWidgetUpdate() && layoutObject() && !isIma geType()) 668 if (!useFallbackContent() && needsWidgetUpdate() && layoutObject() && !isIma geType())
669 lazyReattachIfAttached(); 669 lazyReattachIfAttached();
670 } 670 }
671 671
672 } 672 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698