Align HTMLImageElement relevant mutations to spec

third_party/WebKit/Source/core/html/HTMLPictureElement.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "core/html/HTMLPictureElement.h"
 
 #include "core/HTMLNames.h"
 #include "core/dom/ElementTraversal.h"
 #include "core/frame/UseCounter.h"
 #include "core/html/HTMLImageElement.h"
+#include "core/html/HTMLSourceElement.h"
 #include "core/loader/ImageLoader.h"
 
 namespace blink {
 
 using namespace HTMLNames;
 
 inline HTMLPictureElement::HTMLPictureElement(Document& document)
     : HTMLElement(pictureTag, document)
 {
 }
 
 DEFINE_NODE_FACTORY(HTMLPictureElement)
 
-void HTMLPictureElement::sourceOrMediaChanged()
+void HTMLPictureElement::sourceOrMediaChanged(HTMLElement* sourceElement, Node* next)
 {
-    for (HTMLImageElement* imageElement = Traversal<HTMLImageElement>::firstChild(*this); imageElement; imageElement = Traversal<HTMLImageElement>::nextSibling(*imageElement)) {
-        imageElement->selectSourceURL(ImageLoader::UpdateNormal);
+    bool seenSource = false;
+    Node* node;
+    NodeVector potentialSourceNodes;
+    getChildNodes(*this, potentialSourceNodes);

[esprehn, 2015/12/14 22:52:42]

This copies every kid into a vector, if you're removing every child of a vector
you now copy the kids N times into an on stack vector.

You only need to use getChildNodes() in the cases where your kids will get
mutated out from under you, why do you think that could happen here?

+
+    for (unsigned i = 0; i < potentialSourceNodes.size(); ++i) {
+        node = potentialSourceNodes[i].get();
+        if (sourceElement == node || (next && node == next))
+            seenSource = true;
+        if (isHTMLImageElement(node) && seenSource)
+            toHTMLImageElement(node)->selectSourceURL(ImageLoader::UpdateNormal);
     }
 }
 
 Node::InsertionNotificationRequest HTMLPictureElement::insertedInto(ContainerNode* insertionPoint)
 {
     UseCounter::count(document(), UseCounter::Picture);
     return HTMLElement::insertedInto(insertionPoint);
 }
 
 } // namespace