Align HTMLImageElement relevant mutations to spec

third_party/WebKit/Source/core/dom/ContainerNode.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2013 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
@@ skipping 514 matching lines @@
             if (tail)
                 tail->setNextSibling(n);
             else
                 head = n;
 
             tail = n;
         } else {
             RefPtrWillBeRawPtr<Node> protect(n); // removedFromDocument may remove all references to this node.
             container.document().adoptIfNeeded(*n);
             if (n->inDocument())
-                container.notifyNodeRemoved(*n);
+                container.notifyNodeRemoved(*n, next);
         }
     }
 
     container.setLastChild(nullptr);
 }
 #endif
 
 DEFINE_TRACE(ContainerNode)
 {
     visitor->trace(m_firstChild);
@@ skipping 38 matching lines @@
         exceptionState.throwDOMException(NotFoundError, "The node to be removed is no longer a child of this node. Perhaps it was moved in response to a mutation?");
         return nullptr;
     }
 
     {
         HTMLFrameOwnerElement::UpdateSuspendScope suspendWidgetHierarchyUpdates;
 
         Node* prev = child->previousSibling();
         Node* next = child->nextSibling();
         removeBetween(prev, next, *child);
-        notifyNodeRemoved(*child);
+        notifyNodeRemoved(*child, next);
         childrenChanged(ChildrenChange::forRemoval(*child, prev, next, ChildrenChangeSourceAPI));
     }
     dispatchSubtreeModifiedEvent();
     return child;
 }
 
 void ContainerNode::removeBetween(Node* previousChild, Node* nextChild, Node& oldChild)
 {
     EventDispatchForbiddenScope assertNoEventDispatch;
 
@@ skipping 31 matching lines @@
         return;
 
     ChildListMutationScope(*this).willRemoveChild(oldChild);
     oldChild.notifyMutationObserversNodeWillDetach();
 
     HTMLFrameOwnerElement::UpdateSuspendScope suspendWidgetHierarchyUpdates;
     Node* prev = oldChild.previousSibling();
     Node* next = oldChild.nextSibling();
     removeBetween(prev, next, oldChild);
 
-    notifyNodeRemoved(oldChild);
+    notifyNodeRemoved(oldChild, next);
     childrenChanged(ChildrenChange::forRemoval(oldChild, prev, next, ChildrenChangeSourceParser));
 }
 
 // This differs from other remove functions because it forcibly removes all the children,
 // regardless of read-only status or event exceptions, e.g.
 void ContainerNode::removeChildren(SubtreeModificationAction action)
 {
     if (!m_firstChild)
         return;
 
@@ skipping 31 matching lines @@
         HTMLFrameOwnerElement::UpdateSuspendScope suspendWidgetHierarchyUpdates;
 
         {
             EventDispatchForbiddenScope assertNoEventDispatch;
             ScriptForbiddenScope forbidScript;
 
 #if !ENABLE(OILPAN)
             removedChildren.reserveInitialCapacity(countChildren());
 #endif
             while (RefPtrWillBeRawPtr<Node> child = m_firstChild) {
-                removeBetween(0, child->nextSibling(), *child);
+                Node* next = child->nextSibling();
+                removeBetween(nullptr, next, *child);
 #if !ENABLE(OILPAN)
                 removedChildren.append(child.get());
 #endif
-                notifyNodeRemoved(*child);
+                notifyNodeRemoved(*child, next);
             }
         }
 
         ChildrenChange change = {AllChildrenRemoved, nullptr, nullptr, ChildrenChangeSourceAPI};
         childrenChanged(change);
     }
 
     if (action == DispatchSubtreeModifiedEvent)
         dispatchSubtreeModifiedEvent();
 }
@@ skipping 127 matching lines @@
         // into detached subtrees that are not in a shadow tree.
         if (!inDocument() && !isInShadowTree() && !node.isContainerNode())
             continue;
         if (Node::InsertionShouldCallDidNotifySubtreeInsertions == node.insertedInto(this))
             postInsertionNotificationTargets.append(&node);
         for (ShadowRoot* shadowRoot = node.youngestShadowRoot(); shadowRoot; shadowRoot = shadowRoot->olderShadowRoot())
             notifyNodeInsertedInternal(*shadowRoot, postInsertionNotificationTargets);
     }
 }
 
-void ContainerNode::notifyNodeRemoved(Node& root)
+void ContainerNode::notifyNodeRemoved(Node& root, Node* next)
 {
     ScriptForbiddenScope forbidScript;
     EventDispatchForbiddenScope assertNoEventDispatch;
 
     for (Node& node : NodeTraversal::inclusiveDescendantsOf(root)) {
         // As an optimization we skip notifying Text nodes and other leaf nodes
         // of removal when they're not in the Document tree and not in a shadow root since the virtual
         // call to removedFrom is not needed.
         if (!node.isContainerNode() && !node.isInTreeScope())
             continue;
-        node.removedFrom(this);
+        node.removedFrom(this, node == root ? next : node.nextSibling());

[esprehn, 2015/12/14 22:49:42]

Please revert this change, plumbing next through the whole stack is not correct.
You should just mark the parent <picture> as dirty and async walk the kids. This
puts a branch in the middle of the remove loop just for picture which is not
right.

         for (ShadowRoot* shadowRoot = node.youngestShadowRoot(); shadowRoot; shadowRoot = shadowRoot->olderShadowRoot())
-            notifyNodeRemoved(*shadowRoot);
+            notifyNodeRemoved(*shadowRoot, next);
     }
 }
 
 void ContainerNode::attach(const AttachContext& context)
 {
     attachChildren(context);
     clearChildNeedsStyleRecalc();
     Node::attach(context);
 }
 
@@ skipping 654 matching lines @@
         return true;
 
     if (node->isElementNode() && toElement(node)->shadow())
         return true;
 
     return false;
 }
 #endif
 
 } // namespace blink