Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2404)

Unified Diff: third_party/crashpad/crashpad/util/win/exception_handler_server.cc

Issue 1511483006: Update Crashpad to 583d1dc3efa96ea50f62afa69a598eeed1534edc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@crashpad_intree
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/crashpad/crashpad/util/win/exception_handler_server.cc
diff --git a/third_party/crashpad/crashpad/util/win/exception_handler_server.cc b/third_party/crashpad/crashpad/util/win/exception_handler_server.cc
index 47815ceae6554c8dd72fb8f11ea918254a3cfa58..5559efbe0b816908a23f14f610b92b2bbc14dc7e 100644
--- a/third_party/crashpad/crashpad/util/win/exception_handler_server.cc
+++ b/third_party/crashpad/crashpad/util/win/exception_handler_server.cc
@@ -17,6 +17,8 @@
#include <sddl.h>
#include <string.h>
+#include <utility>
+
#include "base/logging.h"
#include "base/numerics/safe_conversions.h"
#include "base/rand_util.h"
@@ -26,7 +28,6 @@
#include "snapshot/crashpad_info_client_options.h"
#include "snapshot/win/process_snapshot_win.h"
#include "util/file/file_writer.h"
-#include "util/stdlib/move.h"
#include "util/misc/random_string.h"
#include "util/misc/tri_state.h"
#include "util/misc/uuid.h"
@@ -180,7 +181,7 @@ class ClientData {
CreateEvent(nullptr, false /* auto reset */, false, nullptr)),
non_crash_dump_completed_event_(
CreateEvent(nullptr, false /* auto reset */, false, nullptr)),
- process_(crashpad::move(process)),
+ process_(std::move(process)),
crash_exception_information_address_(
crash_exception_information_address),
non_crash_exception_information_address_(
@@ -347,7 +348,7 @@ std::wstring ExceptionHandlerServer::CreatePipe() {
void ExceptionHandlerServer::Run(Delegate* delegate) {
uint64_t shutdown_token = base::RandUint64();
ScopedKernelHANDLE thread_handles[kPipeInstances];
- for (int i = 0; i < arraysize(thread_handles); ++i) {
+ for (size_t i = 0; i < arraysize(thread_handles); ++i) {
HANDLE pipe;
if (first_pipe_instance_.is_valid()) {
pipe = first_pipe_instance_.release();
@@ -399,7 +400,7 @@ void ExceptionHandlerServer::Run(Delegate* delegate) {
}
// Signal to the named pipe instances that they should terminate.
- for (int i = 0; i < arraysize(thread_handles); ++i) {
+ for (size_t i = 0; i < arraysize(thread_handles); ++i) {
ClientToServerMessage message;
memset(&message, 0, sizeof(message));
message.type = ClientToServerMessage::kShutdown;
« no previous file with comments | « third_party/crashpad/crashpad/util/util_test.gyp ('k') | third_party/crashpad/crashpad/util/win/module_version.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698