Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issue 1511483005: clean up doxygen comments for main (Closed)

Created:
5 years ago by rkotlerimgtec
Modified:
5 years ago
CC:
native-client-reviews_googlegroups.com, rich.fuhler_imgtec.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

clean up doxygen comments for main the comments now for the main program describe it very well and the classes and methods in the comments are clickable. BUG= R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=10665a23f5f2d5a59f225bd3e3073bd67d285d24

Patch Set 1 #

Total comments: 4

Patch Set 2 : changes suggested by stichnot #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M src/main.cpp View 1 1 chunk +8 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
rkotlerimgtec
See the file for main in Doxygen after building with "docs". On my machine it's ...
5 years ago (2015-12-08 23:49:24 UTC) #3
Jim Stichnoth
https://codereview.chromium.org/1511483005/diff/1/src/main.cpp File src/main.cpp (right): https://codereview.chromium.org/1511483005/diff/1/src/main.cpp#newcode26 src/main.cpp:26: /// We can only compile the Ice::BrowserCompileServer object with ...
5 years ago (2015-12-10 18:06:57 UTC) #4
rkotlerimgtec
https://codereview.chromium.org/1511483005/diff/1/src/main.cpp File src/main.cpp (right): https://codereview.chromium.org/1511483005/diff/1/src/main.cpp#newcode26 src/main.cpp:26: /// We can only compile the Ice::BrowserCompileServer object with ...
5 years ago (2015-12-10 21:27:39 UTC) #5
Jim Stichnoth
lgtm
5 years ago (2015-12-10 21:53:56 UTC) #6
Jim Stichnoth
5 years ago (2015-12-10 21:57:36 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
10665a23f5f2d5a59f225bd3e3073bd67d285d24 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698