Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Unified Diff: components/offline_pages/offline_page_metadata_store_impl_unittest.cc

Issue 1511483004: [Offline pages] Remove references to MessageLoop from components/offline_pages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@test-refactoring
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/offline_page_metadata_store_impl_unittest.cc
diff --git a/components/offline_pages/offline_page_metadata_store_impl_unittest.cc b/components/offline_pages/offline_page_metadata_store_impl_unittest.cc
index f0f15c49214a9673df3fa8bc2442d994f1245148..32eb90f12ac8d6d56237060904fdf13bd4e875d6 100644
--- a/components/offline_pages/offline_page_metadata_store_impl_unittest.cc
+++ b/components/offline_pages/offline_page_metadata_store_impl_unittest.cc
@@ -8,9 +8,9 @@
#include "base/files/file_path.h"
#include "base/files/scoped_temp_dir.h"
#include "base/memory/scoped_ptr.h"
-#include "base/message_loop/message_loop.h"
-#include "base/run_loop.h"
#include "base/strings/utf_string_conversions.h"
+#include "base/test/test_simple_task_runner.h"
+#include "base/thread_task_runner_handle.h"
#include "components/leveldb_proto/proto_database_impl.h"
#include "components/offline_pages/offline_page_item.h"
#include "components/offline_pages/proto/offline_pages.pb.h"
@@ -36,7 +36,7 @@ class OfflinePageMetadataStoreImplTest : public testing::Test {
OfflinePageMetadataStoreImplTest();
~OfflinePageMetadataStoreImplTest() override;
- void TearDown() override { message_loop_.RunUntilIdle(); }
+ void TearDown() override { task_runner_->RunUntilIdle(); }
jianli 2015/12/08 23:25:25 Is this needed now? If yes, call PumpLoop instead.
fgorski 2015/12/08 23:39:14 Done. This is needed for the lsan tests. We have t
scoped_ptr<OfflinePageMetadataStoreImpl> BuildStore();
void PumpLoop();
@@ -53,12 +53,15 @@ class OfflinePageMetadataStoreImplTest : public testing::Test {
std::vector<OfflinePageItem> offline_pages_;
base::ScopedTempDir temp_directory_;
- base::MessageLoop message_loop_;
- scoped_ptr<base::RunLoop> run_loop_;
+ scoped_refptr<base::TestSimpleTaskRunner> task_runner_;
+ base::ThreadTaskRunnerHandle task_runner_handle_;
};
OfflinePageMetadataStoreImplTest::OfflinePageMetadataStoreImplTest()
- : last_called_callback_(NONE), last_status_(STATUS_NONE) {
+ : last_called_callback_(NONE),
+ last_status_(STATUS_NONE),
+ task_runner_(new base::TestSimpleTaskRunner),
+ task_runner_handle_(task_runner_) {
EXPECT_TRUE(temp_directory_.CreateUniqueTempDir());
}
@@ -66,13 +69,13 @@ OfflinePageMetadataStoreImplTest::~OfflinePageMetadataStoreImplTest() {
}
void OfflinePageMetadataStoreImplTest::PumpLoop() {
- base::RunLoop().RunUntilIdle();
+ task_runner_->RunUntilIdle();
}
scoped_ptr<OfflinePageMetadataStoreImpl>
OfflinePageMetadataStoreImplTest::BuildStore() {
scoped_ptr<OfflinePageMetadataStoreImpl> store(
- new OfflinePageMetadataStoreImpl(message_loop_.task_runner(),
+ new OfflinePageMetadataStoreImpl(base::ThreadTaskRunnerHandle::Get(),
temp_directory_.path()));
store->Load(base::Bind(&OfflinePageMetadataStoreImplTest::LoadCallback,
base::Unretained(this)));

Powered by Google App Engine
This is Rietveld 408576698