[Android] Add support for installing older versions of installed apks.

[Android] Add support for installing older versions of installed apks.

BUG=514449
Committed: https://crrev.com/2dfc54f3c104cb2678b9fed90452fe74de66b626
Cr-Commit-Position: refs/heads/master@{#363909}

[rnephew (Reviews Here), 2015-12-08 16:42:05]

rnephew@chromium.org changed reviewers:
+ jbudorick@chromium.org, mikecase@chromium.org, perezju@chromium.org

[jbudorick, 2015-12-08 16:44:56]

lgtm w/ nits

https://codereview.chromium.org/1511473004/diff/1/build/android/devil/android...
File build/android/devil/android/device_utils.py (right):

https://codereview.chromium.org/1511473004/diff/1/build/android/devil/android...
build/android/devil/android/device_utils.py:559: allow_downgrade: A boolean
indicating if we should allow downgrades.
nit: these should be in the order in which they appear in the function
declaration. (permissions is out of order at the moment, too)

https://codereview.chromium.org/1511473004/diff/1/build/android/devil/android...
build/android/devil/android/device_utils.py:588: allow_downgrade: A boolean
indicating if we should allow downgrades.
nit: same

https://codereview.chromium.org/1511473004/diff/1/build/android/devil/android...
File build/android/devil/android/sdk/adb_wrapper.py (right):

https://codereview.chromium.org/1511473004/diff/1/build/android/devil/android...
build/android/devil/android/sdk/adb_wrapper.py:453: allow_downgrade: (optional)
If set, allows for downgrades.
nit: same

[rnephew (Reviews Here), 2015-12-08 16:57:57]

https://codereview.chromium.org/1511473004/diff/1/build/android/devil/android...
File build/android/devil/android/device_utils.py (right):

https://codereview.chromium.org/1511473004/diff/1/build/android/devil/android...
build/android/devil/android/device_utils.py:559: allow_downgrade: A boolean
indicating if we should allow downgrades.
On 2015/12/08 16:44:56, jbudorick wrote:
> nit: these should be in the order in which they appear in the function
> declaration. (permissions is out of order at the moment, too)

Done.

https://codereview.chromium.org/1511473004/diff/1/build/android/devil/android...
build/android/devil/android/device_utils.py:588: allow_downgrade: A boolean
indicating if we should allow downgrades.
On 2015/12/08 16:44:56, jbudorick wrote:
> nit: same

Done.

https://codereview.chromium.org/1511473004/diff/1/build/android/devil/android...
File build/android/devil/android/sdk/adb_wrapper.py (right):

https://codereview.chromium.org/1511473004/diff/1/build/android/devil/android...
build/android/devil/android/sdk/adb_wrapper.py:453: allow_downgrade: (optional)
If set, allows for downgrades.
On 2015/12/08 16:44:56, jbudorick wrote:
> nit: same

Done.

[rnephew (Reviews Here), 2015-12-08 16:58:07]

The CQ bit was checked by rnephew@chromium.org

[rnephew (Reviews Here), 2015-12-08 16:58:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
jbudorick@chromium.org
Link to the patchset: https://codereview.chromium.org/1511473004/#ps20001
(title: "reorder documentation")

[commit-bot: I haz the power, 2015-12-08 16:59:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1511473004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1511473004/20001

[rnephew (Reviews Here), 2015-12-08 17:21:11]

The CQ bit was unchecked by rnephew@chromium.org

[rnephew (Reviews Here), 2015-12-08 17:21:48]

On 2015/12/08 16:59:18, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/1511473004/20001
> View timeline at
>  https://chromium-cq-status.appspot.com/patch-timeline/1511473004/20001

Unchecking commit, I need to also change adb_install_apk to support this. Will
post another reply when I need it reviewed again.

[rnephew (Reviews Here), 2015-12-08 17:34:22]

ok, changes for adb_install_devices.py in.

[jbudorick, 2015-12-08 17:35:14]

lgtm

[rnephew (Reviews Here), 2015-12-08 17:35:21]

The CQ bit was checked by rnephew@chromium.org

[commit-bot: I haz the power, 2015-12-08 17:35:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1511473004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1511473004/40001

[commit-bot: I haz the power, 2015-12-08 18:06:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-08 18:06:02]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[rnephew (Reviews Here), 2015-12-08 23:31:56]

The CQ bit was checked by rnephew@chromium.org

[commit-bot: I haz the power, 2015-12-08 23:36:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1511473004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1511473004/40001

[commit-bot: I haz the power, 2015-12-09 02:13:25]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-12-09 02:14:34]

Description was changed from

==========
[Android] Add support for installing older versions of installed apks.

BUG=514449
==========

to

==========
[Android] Add support for installing older versions of installed apks.

BUG=514449

Committed: https://crrev.com/2dfc54f3c104cb2678b9fed90452fe74de66b626
Cr-Commit-Position: refs/heads/master@{#363909}
==========

[commit-bot: I haz the power, 2015-12-09 02:14:35]

Patchset 3 (id:??) landed as
https://crrev.com/2dfc54f3c104cb2678b9fed90452fe74de66b626
Cr-Commit-Position: refs/heads/master@{#363909}