Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 151145: Experimental: capture 10 frame stack trace by default. (Closed)

Created:
11 years, 5 months ago by Christian Plesner Hansen
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Enable capture of the top of the stack on error instantiation. Performance impact on v8 benchmarks seems limited. Will be backed out if chrome performance regresses.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -30 lines) Patch
M src/bootstrapper.cc View 1 chunk +7 lines, -9 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +1 line, -1 line 0 comments Download
M src/messages.js View 1 chunk +6 lines, -2 lines 0 comments Download
M src/runtime.h View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime.cc View 1 chunk +29 lines, -15 lines 0 comments Download
M test/mjsunit/stack-traces.js View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Christian Plesner Hansen
11 years, 5 months ago (2009-07-01 11:13:43 UTC) #1
Søren Thygesen Gjesse
11 years, 5 months ago (2009-07-01 16:44:59 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698