Keep pdf_engine in sync with PDF_ENABLE_XFA.

Keep pdf_engine in sync with PDF_ENABLE_XFA.

When the pdf_enable_xfa GYP_DEFINES flag is present, pass
-DPDF_ENABLE_XFA during the build of pdf engine. If the
XFA branch is present, the public XFA header will notice this
flag, and define PDF_USE_XFA in response, which the engine
tests to control its usage of XFA features.  When chrome is
built against master, PDF_USE_XFA is never defined, so this
still works regardless of the setting of the GYP define.

Committed: https://crrev.com/443df85bd8ec78c1787b50d3b4bee8f7187376d6
Cr-Commit-Position: refs/heads/master@{#364466}

[Tom Sepez, 2015-12-09 01:01:45]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2015-12-09 01:01:46]

Lei, for review.

[Lei Zhang, 2015-12-09 01:04:38]

Is GN a separate CL?

[Tom Sepez, 2015-12-09 17:46:37]

On 2015/12/09 01:04:38, Lei Zhang wrote:
> Is GN a separate CL?

Yes, I have to go revisit how variables work in GN.

[Tom Sepez, 2015-12-09 21:20:11]

On 2015/12/09 17:46:37, Tom Sepez wrote:
> On 2015/12/09 01:04:38, Lei Zhang wrote:
> > Is GN a separate CL?
> 
> Yes, I have to go revisit how variables work in GN.

This can't land until after https://codereview.chromium.org/1511183004/ is
present via DEPS roll.

[Tom Sepez, 2015-12-09 21:22:59]

Description was changed from

==========
Keep pdf_engine in sync with XFA (GYP version).

When the pdf_enable_xfa GYP_DEFINES flag is present, pass
-DPDF_ENABLE_XFA during the build of pdf engine. If the
XFA branch is present, the public XFA header will notice this
flag, and define PDF_USE_XFA in response, which the engine
tests to control its usage of XFA features.  When chrome is
built against master, PDF_USE_XFA is never defined, so this
still works regardless of the setting of the GYP define.
==========

to

==========
Keep pdf_engine in sync with PDF_ENABLE_XFA.

When the pdf_enable_xfa GYP_DEFINES flag is present, pass
-DPDF_ENABLE_XFA during the build of pdf engine. If the
XFA branch is present, the public XFA header will notice this
flag, and define PDF_USE_XFA in response, which the engine
tests to control its usage of XFA features.  When chrome is
built against master, PDF_USE_XFA is never defined, so this
still works regardless of the setting of the GYP define.
==========

[Lei Zhang, 2015-12-10 00:20:30]

lgtm, will roll DEPS shortly.

https://codereview.chromium.org/1511443004/diff/20001/pdf/BUILD.gn
File pdf/BUILD.gn (right):

https://codereview.chromium.org/1511443004/diff/20001/pdf/BUILD.gn#newcode5
pdf/BUILD.gn:5: import("//third_party/pdfium/pdfium.gni")
blank line after?

[Tom Sepez, 2015-12-10 17:42:50]

On 2015/12/10 00:20:30, Lei Zhang wrote:
> lgtm, will roll DEPS shortly.
> 
> https://codereview.chromium.org/1511443004/diff/20001/pdf/BUILD.gn
> File pdf/BUILD.gn (right):
> 
> https://codereview.chromium.org/1511443004/diff/20001/pdf/BUILD.gn#newcode5
> pdf/BUILD.gn:5: import("//third_party/pdfium/pdfium.gni")
> blank line after?

Done

[Tom Sepez, 2015-12-10 17:42:51]

On 2015/12/10 00:20:30, Lei Zhang wrote:
> lgtm, will roll DEPS shortly.
> 
> https://codereview.chromium.org/1511443004/diff/20001/pdf/BUILD.gn
> File pdf/BUILD.gn (right):
> 
> https://codereview.chromium.org/1511443004/diff/20001/pdf/BUILD.gn#newcode5
> pdf/BUILD.gn:5: import("//third_party/pdfium/pdfium.gni")
> blank line after?

Done

[Tom Sepez, 2015-12-10 20:30:47]

The CQ bit was checked by tsepez@chromium.org

[Tom Sepez, 2015-12-10 20:30:47]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/1511443004/#ps40001
(title: "Blank line.")

[commit-bot: I haz the power, 2015-12-10 20:35:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1511443004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1511443004/40001

[commit-bot: I haz the power, 2015-12-10 20:44:13]

Description was changed from

==========
Keep pdf_engine in sync with PDF_ENABLE_XFA.

When the pdf_enable_xfa GYP_DEFINES flag is present, pass
-DPDF_ENABLE_XFA during the build of pdf engine. If the
XFA branch is present, the public XFA header will notice this
flag, and define PDF_USE_XFA in response, which the engine
tests to control its usage of XFA features.  When chrome is
built against master, PDF_USE_XFA is never defined, so this
still works regardless of the setting of the GYP define.
==========

to

==========
Keep pdf_engine in sync with PDF_ENABLE_XFA.

When the pdf_enable_xfa GYP_DEFINES flag is present, pass
-DPDF_ENABLE_XFA during the build of pdf engine. If the
XFA branch is present, the public XFA header will notice this
flag, and define PDF_USE_XFA in response, which the engine
tests to control its usage of XFA features.  When chrome is
built against master, PDF_USE_XFA is never defined, so this
still works regardless of the setting of the GYP define.
==========

[commit-bot: I haz the power, 2015-12-10 20:44:14]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-12-10 20:45:09]

Description was changed from

==========
Keep pdf_engine in sync with PDF_ENABLE_XFA.

When the pdf_enable_xfa GYP_DEFINES flag is present, pass
-DPDF_ENABLE_XFA during the build of pdf engine. If the
XFA branch is present, the public XFA header will notice this
flag, and define PDF_USE_XFA in response, which the engine
tests to control its usage of XFA features.  When chrome is
built against master, PDF_USE_XFA is never defined, so this
still works regardless of the setting of the GYP define.
==========

to

==========
Keep pdf_engine in sync with PDF_ENABLE_XFA.

When the pdf_enable_xfa GYP_DEFINES flag is present, pass
-DPDF_ENABLE_XFA during the build of pdf engine. If the
XFA branch is present, the public XFA header will notice this
flag, and define PDF_USE_XFA in response, which the engine
tests to control its usage of XFA features.  When chrome is
built against master, PDF_USE_XFA is never defined, so this
still works regardless of the setting of the GYP define.

Committed: https://crrev.com/443df85bd8ec78c1787b50d3b4bee8f7187376d6
Cr-Commit-Position: refs/heads/master@{#364466}
==========

[commit-bot: I haz the power, 2015-12-10 20:45:10]

Patchset 3 (id:??) landed as
https://crrev.com/443df85bd8ec78c1787b50d3b4bee8f7187376d6
Cr-Commit-Position: refs/heads/master@{#364466}