Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1511433005: Version 4.8.271.9 (cherry-pick) (Closed)

Created:
5 years ago by jochen (gone - plz use gerrit)
Modified:
5 years ago
Reviewers:
Michael Hablich
CC:
v8-reviews_googlegroups.com, Paweł Hajdan Jr., ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@4.8
Target Ref:
refs/pending/branch-heads/4.8
Project:
v8
Visibility:
Public.

Description

Version 4.8.271.9 (cherry-pick) Merged 086d4598473fe25b6b8f802998d6e85e90625136 [crankshaft] Loads and stores to typed arrays have to reference the backing store holder BUG=v8:1827 LOG=N TBR=hablich@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/9bd13de4b62f727ec11b4d5ccc4afb0bcaef7a68

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+328 lines, -199 lines) Patch
M include/v8-version.h View 1 chunk +1 line, -1 line 0 comments Download
M src/code-stubs-hydrogen.cc View 12 chunks +26 lines, -23 lines 0 comments Download
M src/crankshaft/arm/lithium-arm.h View 3 chunks +9 lines, -4 lines 0 comments Download
M src/crankshaft/arm/lithium-arm.cc View 4 chunks +7 lines, -4 lines 0 comments Download
M src/crankshaft/arm64/lithium-arm64.h View 9 chunks +24 lines, -18 lines 0 comments Download
M src/crankshaft/arm64/lithium-arm64.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M src/crankshaft/hydrogen.h View 1 chunk +2 lines, -5 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 37 chunks +82 lines, -74 lines 0 comments Download
M src/crankshaft/hydrogen-instructions.h View 12 chunks +46 lines, -16 lines 0 comments Download
M src/crankshaft/hydrogen-instructions.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/ia32/lithium-ia32.h View 3 chunks +9 lines, -4 lines 0 comments Download
M src/crankshaft/ia32/lithium-ia32.cc View 5 chunks +8 lines, -5 lines 0 comments Download
M src/crankshaft/mips/lithium-mips.h View 3 chunks +9 lines, -4 lines 0 comments Download
M src/crankshaft/mips/lithium-mips.cc View 4 chunks +7 lines, -4 lines 0 comments Download
M src/crankshaft/mips64/lithium-mips64.h View 3 chunks +9 lines, -4 lines 0 comments Download
M src/crankshaft/mips64/lithium-mips64.cc View 4 chunks +7 lines, -4 lines 0 comments Download
M src/crankshaft/ppc/lithium-ppc.h View 3 chunks +9 lines, -4 lines 0 comments Download
M src/crankshaft/ppc/lithium-ppc.cc View 3 chunks +7 lines, -4 lines 0 comments Download
M src/crankshaft/x64/lithium-x64.h View 4 chunks +9 lines, -4 lines 0 comments Download
M src/crankshaft/x64/lithium-x64.cc View 4 chunks +7 lines, -4 lines 0 comments Download
M src/crankshaft/x87/lithium-x87.h View 3 chunks +9 lines, -4 lines 0 comments Download
M src/crankshaft/x87/lithium-x87.cc View 5 chunks +8 lines, -5 lines 0 comments Download
A test/mjsunit/regress/typed-array-lifetime.js View 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
jochen (gone - plz use gerrit)
5 years ago (2015-12-09 08:32:37 UTC) #1
Michael Hablich
On 2015/12/09 08:32:37, jochen wrote: lgtm
5 years ago (2015-12-09 08:33:25 UTC) #2
jochen (gone - plz use gerrit)
5 years ago (2015-12-09 08:34:17 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
9bd13de4b62f727ec11b4d5ccc4afb0bcaef7a68.

Powered by Google App Engine
This is Rietveld 408576698