Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 151143002: Make gyp autodetection of host_arch work for 64-bit kernel and 32-bit userland (Closed)

Created:
6 years, 10 months ago by Paweł Hajdan Jr.
Modified:
6 years, 10 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Make gyp autodetection of host_arch work for 64-bit kernel and 32-bit userland Before it would get confused and detect above situation as 64-bit, leading to build failures. So far we've used explicit target_arch in buildbot configuration as a workaround, but with recipes for simplicity it'd be better if no such workaround was needed. BUG=none R=maruel@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248214

Patch Set 1 #

Total comments: 8

Patch Set 2 : fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -6 lines) Patch
M build/common.gypi View 1 1 chunk +1 line, -6 lines 0 comments Download
A build/linux/detect_host_arch.py View 1 1 chunk +35 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Paweł Hajdan Jr.
6 years, 10 months ago (2014-01-31 04:59:18 UTC) #1
Marc-Antoine Ruel (Google)
lgtm with nits https://codereview.chromium.org/151143002/diff/1/build/detect_host_arch.py File build/detect_host_arch.py (right): https://codereview.chromium.org/151143002/diff/1/build/detect_host_arch.py#newcode1 build/detect_host_arch.py:1: #!/usr/bin/env python Please rename this script ...
6 years, 10 months ago (2014-01-31 14:47:47 UTC) #2
Paweł Hajdan Jr.
https://codereview.chromium.org/151143002/diff/1/build/detect_host_arch.py File build/detect_host_arch.py (right): https://codereview.chromium.org/151143002/diff/1/build/detect_host_arch.py#newcode1 build/detect_host_arch.py:1: #!/usr/bin/env python On 2014/01/31 14:47:47, Marc-Antoine Ruel (Google) wrote: ...
6 years, 10 months ago (2014-01-31 15:44:04 UTC) #3
M-A Ruel
https://codereview.chromium.org/151143002/diff/1/build/detect_host_arch.py File build/detect_host_arch.py (right): https://codereview.chromium.org/151143002/diff/1/build/detect_host_arch.py#newcode5 build/detect_host_arch.py:5: On 2014/01/31 15:44:04, Paweł Hajdan Jr. wrote: > On ...
6 years, 10 months ago (2014-01-31 16:04:57 UTC) #4
Paweł Hajdan Jr.
https://codereview.chromium.org/151143002/diff/1/build/detect_host_arch.py File build/detect_host_arch.py (right): https://codereview.chromium.org/151143002/diff/1/build/detect_host_arch.py#newcode5 build/detect_host_arch.py:5: On 2014/01/31 16:04:58, M-A Ruel wrote: > What about ...
6 years, 10 months ago (2014-01-31 16:08:35 UTC) #5
Paweł Hajdan Jr.
6 years, 10 months ago (2014-01-31 17:24:01 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r248214 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698