Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1511413009: Revert of Roll third_party/freetype-android/src to VER-2-6-2. (Closed)

Created:
5 years ago by johnme
Modified:
5 years ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Roll third_party/freetype-android/src to VER-2-6-2. (patchset #1 id:1 of https://codereview.chromium.org/1518643003/ ) Reason for revert: This caused the following layout tests to fail flakily with very minor font rendering changes: css1/classification/list_style.html svg/W3C-SVG-1.1-SE/coords-dom-02-f.svg css1/formatting_model/horizontal_formatting.html css1/formatting_model/canvas.html css1/cascade/important.html css1/font_properties/font_style.html css1/font_properties/font_variant.html css1/color_and_background/background_color.html css1/classification/list_style_position.html svg/batik/text/textAnchor3.svg fast/text/chromium-linux-fontconfig-renderstyle.html svg/canvas/canvas-pattern-svg.html css1/color_and_background/color.html fast/hidpi/clip-text-in-hidpi.html editing/caret/caret-color.html css1/classification/list_style_image.html css1/text_properties/text_align.html fast/invalid/009.html fast/compact/002.html First failure: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/42280 Test output, including pixel diffs: https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Android__Nexus4_/42280/layout-test-results/results.html Normally we could just rebaseline the layout tests, but this is complicated by the fact that the failures are flaky. Specifically, all the tests failed in every build from 42280 until 42296 (the most recent one), except for builds 42282, 42284 and 42286 in which all the tests passed! Original issue's description: > Roll third_party/freetype-android/src to VER-2-6-2. > > https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/30fe5e762e06261..66cf29b1bc869b > > This updates from VER-2-6-1 + 1 to VER-2-6-2. > > It is expected that this will change the weight of CFF fonts. > If this becomes undesireable, there is a patch which can be applied. > > BUG=chromium:551028 > > Committed: https://crrev.com/a7a845a523c9f2f3c481ec99c0c35646f9e5ea7f > Cr-Commit-Position: refs/heads/master@{#364438} TBR=jshin@chromium.org,wangxianzhu@chromium.org,bungeman@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:551028 Committed: https://crrev.com/c70e3c259219cedd782b7e3b3dbf5c0234b4b947 Cr-Commit-Position: refs/heads/master@{#364670}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -30 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M third_party/freetype-android/README.chromium View 2 chunks +4 lines, -6 lines 0 comments Download
M third_party/freetype-android/include/freetype-android-config/ftoption.h View 4 chunks +5 lines, -23 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
johnme
Created Revert of Roll third_party/freetype-android/src to VER-2-6-2.
5 years ago (2015-12-11 11:30:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1511413009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1511413009/1
5 years ago (2015-12-11 11:32:13 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-11 11:33:56 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c70e3c259219cedd782b7e3b3dbf5c0234b4b947 Cr-Commit-Position: refs/heads/master@{#364670}
5 years ago (2015-12-11 11:34:56 UTC) #6
bungeman-chromium
On 2015/12/11 11:34:56, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as ...
5 years ago (2015-12-11 14:32:42 UTC) #7
bungeman-chromium
On 2015/12/11 14:32:42, bungeman2 wrote: > On 2015/12/11 11:34:56, commit-bot: I haz the power wrote: ...
5 years ago (2015-12-11 14:59:22 UTC) #8
johnme
5 years ago (2015-12-11 15:28:15 UTC) #9
Message was sent while issue was closed. 
On 2015/12/11 14:59:22, bungeman2 wrote:
> On 2015/12/11 14:32:42, bungeman2 wrote:
> > On 2015/12/11 11:34:56, commit-bot: I haz the power wrote:
> > > Patchset 1 (id:??) landed as
> > > https://crrev.com/c70e3c259219cedd782b7e3b3dbf5c0234b4b947
> > > Cr-Commit-Position: refs/heads/master@{#364670}
> > 
> > Unfortunately, upon inspection, the reason why builds 42282, 42284 and 42286
> > 'passed' was because they *did not* run *any* of the layout tests. If they
> had,
> > I'm sure they would have produced identical results. I'll try a new roll
with
> > some [ NeedsRebaseline ]. Fortunately, this doesn't appear to actually be
> flaky.
> 
> The builds that 'passed' all end up reporting
> 
> 19:18:17.243 13426 0 tests ran as expected (216 didn't run).
> 19:18:17.243 13426 
> => Results: 0/216 tests passed (0.0%)
> 
> => Tests to be fixed (216):
> 
> => Tests that will only be fixed if they crash (WONTFIX) (0):
> 
> This should at least make the step purple or red, not green. I've filed
> https://crbug.com/569032 to track this.

Good spot, thanks for filing that.

Powered by Google App Engine
This is Rietveld 408576698