Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: scripts/slave/recipes/android_webview_cts_tests.py

Issue 1511403002: Revert "[Android] Add context manager to record logcat during step(s)." (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipes/android_webview_cts_tests.py
diff --git a/scripts/slave/recipes/android_webview_cts_tests.py b/scripts/slave/recipes/android_webview_cts_tests.py
index cc626110a29052ab899a685ba42f821a0b3f177e..4b92c3c0abea5bbd4c6fc5c402454af6b78b376a 100644
--- a/scripts/slave/recipes/android_webview_cts_tests.py
+++ b/scripts/slave/recipes/android_webview_cts_tests.py
@@ -131,9 +131,8 @@ def RunSteps(api):
[['unexpected failures:', unexpected_test_failures],
['not executed:', not_executed_tests]]))
- logcat_file = api.chromium.output_dir.join('full_logcat')
- api.chromium_android.logcat_dump(output_logcat_file=logcat_file)
- api.chromium_android.stack_tool_steps(logcat_file=logcat_file)
+ api.chromium_android.logcat_dump()
+ api.chromium_android.stack_tool_steps()
api.chromium_android.test_report()
if unexpected_test_failures:

Powered by Google App Engine
This is Rietveld 408576698