scripts/slave/recipe_modules/chromium_android/config.py - Issue 1511403002: Revert "[Android] Add context manager to record logcat during step(s)."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/chromium_android/config.py

Issue 1511403002: Revert "[Android] Add context manager to record logcat during step(s)." (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipe_modules/chromium_android/api.py ('k') | scripts/slave/recipe_modules/chromium_android/example.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipe_modules/chromium_android/config.py

diff --git a/scripts/slave/recipe_modules/chromium_android/config.py b/scripts/slave/recipe_modules/chromium_android/config.py

index f42adc4b61f185e14fbb20ea75ee43d0a625a19e..875fe1daefac07f07840d14a8c6c421e8dc5e2a2 100644

--- a/scripts/slave/recipe_modules/chromium_android/config.py

+++ b/scripts/slave/recipe_modules/chromium_android/config.py

@@ -29,7 +29,6 @@ def BaseConfig(INTERNAL=False, REPO_NAME=None, REPO_URL=None,

tests = List(inner_type=basestring),

cr_build_android = Static(Path('[CHECKOUT]', 'build', 'android')),

test_runner = Single(Path),

- default_logcat_dir = Single(Path),

gclient_custom_deps = Dict(value_type=(basestring, types.NoneType)),

channel = Single(basestring, empty_val='chrome'),

gclient_custom_vars = Dict(value_type=(basestring, types.NoneType)),

@@ -47,7 +46,6 @@ config_ctx = config_item_context(BaseConfig)

@config_ctx(is_root=True)

def base_config(c):

- c.default_logcat_dir = Path('[CHECKOUT]', 'out', 'logcat_dir')

c.internal_dir_name = 'clank'

c.test_runner = Path('[CHECKOUT]', 'build', 'android', 'test_runner.py')

« no previous file with comments | « scripts/slave/recipe_modules/chromium_android/api.py ('k') | scripts/slave/recipe_modules/chromium_android/example.py » ('j') | no next file with comments »