scripts/slave/recipes/cronet.expected/android_cronet_builder__dbg_.json - Issue 1511403002: Revert "[Android] Add context manager to record logcat during step(s)."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/cronet.expected/android_cronet_builder__dbg_.json

Issue 1511403002: Revert "[Android] Add context manager to record logcat during step(s)." (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipes/cronet.expected/android_cronet_builder.json ('k') | scripts/slave/recipes/cronet.expected/android_cronet_data_reduction_proxy_builder.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/cronet.expected/android_cronet_builder__dbg_.json

diff --git a/scripts/slave/recipes/cronet.expected/android_cronet_builder__dbg_.json b/scripts/slave/recipes/cronet.expected/android_cronet_builder__dbg_.json

index 66cf9a66adb4b9462f7a1d1ad287a6e63e7bf0c3..12c43b2936744ca67fad3c86db3dcd6ba85d9553 100644

--- a/scripts/slave/recipes/cronet.expected/android_cronet_builder__dbg_.json

+++ b/scripts/slave/recipes/cronet.expected/android_cronet_builder__dbg_.json

@@ -230,7 +230,7 @@

"[BUILD]/scripts/slave/daemonizer.py",

"--",

"[SLAVE_BUILD]/src/build/android/adb_logcat_monitor.py",

- "[SLAVE_BUILD]/src/out/logcat_dir"

+ "[SLAVE_BUILD]/src/out/logcat"

"cwd": "[SLAVE_BUILD]",

"env": {

@@ -523,7 +523,7 @@

"[SLAVE_BUILD]/src/out/Debug/full_log",

"--",

"[SLAVE_BUILD]/src/build/android/adb_logcat_printer.py",

- "[SLAVE_BUILD]/src/out/logcat_dir"

+ "[SLAVE_BUILD]/src/out/logcat"

"cwd": "[SLAVE_BUILD]",

"name": "logcat_dump"