Issue 1511383002: Revert "Canonical output ordering for constants."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1511383002: Revert "Canonical output ordering for constants." (Closed)

Created:
5 years ago by sra1

Modified:
5 years ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 5 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -313 lines)			Patch
M	pkg/compiler/lib/src/js_backend/namer.dart	View	1 chunk	+0 lines, -2 lines	0 comments	Download
D	pkg/compiler/lib/src/js_emitter/constant_ordering.dart	View	1 chunk	+0 lines, -212 lines	0 comments	Download
M	pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart	View	2 chunks	+5 lines, -4 lines	0 comments	Download
M	pkg/compiler/lib/src/js_emitter/lazy_emitter/model_emitter.dart	View	2 chunks	+3 lines, -4 lines	0 comments	Download
M	pkg/compiler/lib/src/js_emitter/startup_emitter/model_emitter.dart	View	2 chunks	+3 lines, -4 lines	0 comments	Download
D	tests/compiler/dart2js_extra/many_constants_test.dart	View	1 chunk	+0 lines, -87 lines	0 comments	Download

Total messages: 3 (1 generated)

sra1

Committed patchset #1 (id:1) manually as cfb97d053e0a5259d32ad48d5a831acf0646b14c (presubmit successful).

5 years ago (2015-12-10 01:23:41 UTC) #2

Message was sent while issue was closed.

lgtm