Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 1511363002: Make AstConsString::length constant-time instead of O(N) (Closed)

Created:
5 years ago by adamk
Modified:
5 years ago
Reviewers:
Dan Ehrenberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make AstConsString::length constant-time instead of O(N) This makes it consistent in behavior with its heap-resident equivalent. Also some minor cleanup in the AstString class hierarchy. BUG=v8:4595 LOG=n Committed: https://crrev.com/8a7e6fc34dbb8a5102e9f256fa343ce49de5dc28 Cr-Commit-Position: refs/heads/master@{#32733}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -7 lines) Patch
M src/ast/ast-value-factory.h View 2 chunks +5 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
adamk
Relatively minor cleanup/reasonable-ness fix found while investigating FNI bug.
5 years ago (2015-12-10 00:15:44 UTC) #2
Dan Ehrenberg
lgtm
5 years ago (2015-12-10 01:02:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1511363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1511363002/1
5 years ago (2015-12-10 01:11:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-10 04:42:00 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-10 04:42:49 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8a7e6fc34dbb8a5102e9f256fa343ce49de5dc28
Cr-Commit-Position: refs/heads/master@{#32733}

Powered by Google App Engine
This is Rietveld 408576698