Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 1511353002: New Mojom parser: Fix error message for invalid enum value initailizers. (Closed)

Created:
5 years ago by rudominer
Modified:
5 years ago
Reviewers:
azani
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

New Mojom parser: Fix error message for invalid enum value initailizers. BUG=#461 - In the case that an EnumValue is being used as an enum value initializer for an Enum of the wrong type, the error message now mentions "used as an initializer" instead of "being assigned to" because an enum value initializer declaration is not really an assignment. - We now capture the name of the enum vale being assigned to for the sake of the error message. - We mention the fully-qualified name of the Enum in error messages. - Found another occurrence of "Error:" that I missed last time. R=azani@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/de332fca6d3629ae8a595fd0c1a6fb29f9fec67d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -12 lines) Patch
M mojom/mojom_parser/mojom/computed_data.go View 1 chunk +1 line, -1 line 0 comments Download
M mojom/mojom_parser/mojom/types.go View 2 chunks +14 lines, -5 lines 0 comments Download
M mojom/mojom_parser/parser/parsing.go View 3 chunks +3 lines, -3 lines 0 comments Download
M mojom/mojom_parser/parser/resolution_test.go View 3 chunks +49 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
rudominer
Hi Alex, ptal.
5 years ago (2015-12-09 23:52:04 UTC) #3
azani
lgtm
5 years ago (2015-12-10 19:45:02 UTC) #4
rudominer
5 years ago (2015-12-10 20:01:51 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
de332fca6d3629ae8a595fd0c1a6fb29f9fec67d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698