Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(813)

Issue 1511333003: [Sync] Enable ProfileSyncServiceAutofillTest.ServerChangeRace (Closed)

Created:
5 years ago by pavely
Modified:
5 years ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews, tim+watch_chromium.org, pvalenzuela+watch_chromium.org, maxbogue+watch_chromium.org, plaree+watch_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Enable ProfileSyncServiceAutofillTest.ServerChangeRace Test was disabled because number of calls to PersonalDataManager::Refresh didn't match expectation. I think this happened because calls to Refresh were posted to UI thread, but test didn't run message loop at the end of the test. BUG=57884 R=zea@chromium.org Committed: https://crrev.com/14e9197c285a1edc95dc7e2f314f814fcc0a853f Cr-Commit-Position: refs/heads/master@{#364439}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M chrome/browser/sync/profile_sync_service_autofill_unittest.cc View 4 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
pavely
5 years ago (2015-12-10 01:15:10 UTC) #1
Nicolas Zea
lgtm
5 years ago (2015-12-10 18:58:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1511333003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1511333003/1
5 years ago (2015-12-10 19:08:01 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-10 19:51:49 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/14e9197c285a1edc95dc7e2f314f814fcc0a853f Cr-Commit-Position: refs/heads/master@{#364439}
5 years ago (2015-12-10 19:52:37 UTC) #7
Jeffrey Yasskin
5 years ago (2015-12-14 21:17:16 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1523083002/ by jyasskin@chromium.org.

The reason for reverting is: This is broken on the DrMemory bot:
http://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%28...

[ RUN      ] ProfileSyncServiceAutofillTest.ServerChangeRace

GMOCK WARNING:
Uninteresting mock function call - returning directly.
    Function call: RegisterDataTypes(@05A1F340 8-byte object <C0-B7 D2-11 0E-BB
12-00>)
NOTE: You can safely ignore the above warning unless this call should not
happen.  Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean
to enforce the call.  See
http://code.google.com/p/googlemock/wiki/CookBook#Knowing_When_to_Expect for
details.
[3560:2356:1210/173205:14452494:WARNING:sync_backend_registrar.cc(95)] No
history worker -- removing TYPED_URLS
[3560:2356:1210/173205:14452494:WARNING:sync_backend_registrar.cc(99)] No
password worker -- removing PASSWORDS
[3560:2356:1210/173205:14452494:WARNING:sync_encryption_handler_impl.cc(989)]
Nigori had empty encryption keybag.
[3560:2436:1210/173205:14452697:WARNING:sync_backend_registrar.cc(95)] No
history worker -- removing TYPED_URLS
[3560:2436:1210/173205:14452697:WARNING:sync_backend_registrar.cc(99)] No
password worker -- removing PASSWORDS
[3560:2436:1210/173205:14452697:WARNING:sync_backend_registrar.cc(95)] No
history worker -- removing TYPED_URLS
[3560:2436:1210/173205:14452697:WARNING:sync_backend_registrar.cc(99)] No
password worker -- removing PASSWORDS
c:\b\build\slave\drm-cr\build\src\chrome\browser\sync\profile_sync_service_autofill_unittest.cc(1318):
error: Value of: sync_entries.size()
  Actual: 2
Expected: 3U
Which is: 3
c:\b\build\slave\drm-cr\build\src\chrome\browser\sync\profile_sync_service_autofill_unittest.cc(1284):
error: Actual function call count doesn't match
EXPECT_CALL(*personal_data_manager_, Refresh())...
         Expected: to be called 3 times
           Actual: called twice - unsatisfied and active
[  FAILED  ] ProfileSyncServiceAutofillTest.ServerChangeRace (356 ms).

Powered by Google App Engine
This is Rietveld 408576698