Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(621)

Unified Diff: third_party/libaddressinput/chromium/chrome_downloader_impl.h

Issue 151133002: libaddressinput - one less copy when downloading data (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: re-up Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/libaddressinput/chromium/chrome_downloader_impl.h
diff --git a/third_party/libaddressinput/chromium/chrome_downloader_impl.h b/third_party/libaddressinput/chromium/chrome_downloader_impl.h
index 09a9e7ae4f21d128d1e478947699993d6d501ea1..2f0bf0d703a3c3cd17f6bff6c832dcec5616677d 100644
--- a/third_party/libaddressinput/chromium/chrome_downloader_impl.h
+++ b/third_party/libaddressinput/chromium/chrome_downloader_impl.h
@@ -36,16 +36,21 @@ class ChromeDownloaderImpl : public ::i18n::addressinput::Downloader,
private:
struct Request {
- Request(const std::string& url, scoped_ptr<Callback> callback);
+ Request(const std::string& url,
+ scoped_ptr<net::URLFetcher> fetcher,
+ scoped_ptr<Callback> callback);
std::string url;
+ // The data that's received.
+ std::string data;
+ // The object that manages retrieving the data.
+ scoped_ptr<net::URLFetcher> fetcher;
scoped_ptr<Callback> callback;
};
net::URLRequestContextGetter* const getter_; // weak
- // Maps from active url fetcher to request metadata. Both the key and value
- // are owned.
+ // Maps from active url fetcher to request metadata. The value is owned.
std::map<const net::URLFetcher*, Request*> requests_;
DISALLOW_COPY_AND_ASSIGN(ChromeDownloaderImpl);
« no previous file with comments | « net/url_request/test_url_fetcher_factory.cc ('k') | third_party/libaddressinput/chromium/chrome_downloader_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698