Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1018)

Unified Diff: test/cctest/test-object-observe.cc

Issue 1511293002: Pass --harmony-object-observe in tests that depend on it (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/test-microtask-delivery.cc ('k') | test/mjsunit/es7/regress/regress-443982.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-object-observe.cc
diff --git a/test/cctest/test-object-observe.cc b/test/cctest/test-object-observe.cc
index 9a82cce8f50586bf281de46f17ce56f5e25759c7..a52fb600a9414088a2063ddd2fdf88451103c358 100644
--- a/test/cctest/test-object-observe.cc
+++ b/test/cctest/test-object-observe.cc
@@ -42,6 +42,7 @@ inline int32_t ToInt32(v8::Local<v8::Value> value) {
TEST(PerIsolateState) {
+ i::FLAG_harmony_object_observe = true;
HandleScope scope(CcTest::isolate());
LocalContext context1(CcTest::isolate());
@@ -105,6 +106,7 @@ TEST(PerIsolateState) {
TEST(EndOfMicrotaskDelivery) {
+ i::FLAG_harmony_object_observe = true;
HandleScope scope(CcTest::isolate());
LocalContext context(CcTest::isolate());
CompileRun(
@@ -118,6 +120,7 @@ TEST(EndOfMicrotaskDelivery) {
TEST(DeliveryOrdering) {
+ i::FLAG_harmony_object_observe = true;
HandleScope scope(CcTest::isolate());
LocalContext context(CcTest::isolate());
CompileRun(
@@ -149,6 +152,7 @@ TEST(DeliveryOrdering) {
TEST(DeliveryCallbackThrows) {
+ i::FLAG_harmony_object_observe = true;
HandleScope scope(CcTest::isolate());
LocalContext context(CcTest::isolate());
CompileRun(
@@ -177,6 +181,7 @@ TEST(DeliveryCallbackThrows) {
TEST(DeliveryChangesMutationInCallback) {
+ i::FLAG_harmony_object_observe = true;
HandleScope scope(CcTest::isolate());
LocalContext context(CcTest::isolate());
CompileRun(
@@ -202,6 +207,7 @@ TEST(DeliveryChangesMutationInCallback) {
TEST(DeliveryOrderingReentrant) {
+ i::FLAG_harmony_object_observe = true;
HandleScope scope(CcTest::isolate());
LocalContext context(CcTest::isolate());
CompileRun(
@@ -233,6 +239,7 @@ TEST(DeliveryOrderingReentrant) {
TEST(DeliveryOrderingDeliverChangeRecords) {
+ i::FLAG_harmony_object_observe = true;
HandleScope scope(CcTest::isolate());
LocalContext context(CcTest::isolate());
CompileRun(
@@ -257,6 +264,7 @@ TEST(DeliveryOrderingDeliverChangeRecords) {
TEST(ObjectHashTableGrowth) {
+ i::FLAG_harmony_object_observe = true;
HandleScope scope(CcTest::isolate());
// Initializing this context sets up initial hash tables.
LocalContext context(CcTest::isolate());
@@ -352,6 +360,7 @@ static void ExpectRecords(v8::Isolate* isolate, Local<Value> records,
arraysize(expectations))
TEST(APITestBasicMutation) {
+ i::FLAG_harmony_object_observe = true;
v8::Isolate* v8_isolate = CcTest::isolate();
HandleScope scope(v8_isolate);
LocalContext context(v8_isolate);
@@ -411,6 +420,7 @@ TEST(APITestBasicMutation) {
TEST(HiddenPrototypeObservation) {
+ i::FLAG_harmony_object_observe = true;
v8::Isolate* v8_isolate = CcTest::isolate();
HandleScope scope(v8_isolate);
LocalContext context(v8_isolate);
@@ -473,6 +483,7 @@ static int NumberOfElements(i::Handle<i::JSWeakMap> map) {
TEST(ObservationWeakMap) {
+ i::FLAG_harmony_object_observe = true;
HandleScope scope(CcTest::isolate());
LocalContext context(CcTest::isolate());
CompileRun(
@@ -543,6 +554,7 @@ static int TestObserveSecurity(Local<Context> observer_context,
TEST(ObserverSecurityAAA) {
+ i::FLAG_harmony_object_observe = true;
v8::Isolate* isolate = CcTest::isolate();
v8::HandleScope scope(isolate);
v8::Local<Context> contextA = Context::New(isolate);
@@ -551,6 +563,7 @@ TEST(ObserverSecurityAAA) {
TEST(ObserverSecurityA1A2A3) {
+ i::FLAG_harmony_object_observe = true;
v8::Isolate* isolate = CcTest::isolate();
v8::HandleScope scope(isolate);
@@ -568,6 +581,7 @@ TEST(ObserverSecurityA1A2A3) {
TEST(ObserverSecurityAAB) {
+ i::FLAG_harmony_object_observe = true;
v8::Isolate* isolate = CcTest::isolate();
v8::HandleScope scope(isolate);
v8::Local<Context> contextA = Context::New(isolate);
@@ -577,6 +591,7 @@ TEST(ObserverSecurityAAB) {
TEST(ObserverSecurityA1A2B) {
+ i::FLAG_harmony_object_observe = true;
v8::Isolate* isolate = CcTest::isolate();
v8::HandleScope scope(isolate);
@@ -593,6 +608,7 @@ TEST(ObserverSecurityA1A2B) {
TEST(ObserverSecurityABA) {
+ i::FLAG_harmony_object_observe = true;
v8::Isolate* isolate = CcTest::isolate();
v8::HandleScope scope(isolate);
v8::Local<Context> contextA = Context::New(isolate);
@@ -602,6 +618,7 @@ TEST(ObserverSecurityABA) {
TEST(ObserverSecurityA1BA2) {
+ i::FLAG_harmony_object_observe = true;
v8::Isolate* isolate = CcTest::isolate();
v8::HandleScope scope(isolate);
v8::Local<Context> contextA1 = Context::New(isolate);
@@ -617,6 +634,7 @@ TEST(ObserverSecurityA1BA2) {
TEST(ObserverSecurityBAA) {
+ i::FLAG_harmony_object_observe = true;
v8::Isolate* isolate = CcTest::isolate();
v8::HandleScope scope(isolate);
v8::Local<Context> contextA = Context::New(isolate);
@@ -626,6 +644,7 @@ TEST(ObserverSecurityBAA) {
TEST(ObserverSecurityBA1A2) {
+ i::FLAG_harmony_object_observe = true;
v8::Isolate* isolate = CcTest::isolate();
v8::HandleScope scope(isolate);
v8::Local<Context> contextA1 = Context::New(isolate);
@@ -641,6 +660,7 @@ TEST(ObserverSecurityBA1A2) {
TEST(ObserverSecurityNotify) {
+ i::FLAG_harmony_object_observe = true;
v8::Isolate* isolate = CcTest::isolate();
v8::HandleScope scope(isolate);
v8::Local<Context> contextA = Context::New(isolate);
@@ -676,6 +696,7 @@ TEST(ObserverSecurityNotify) {
TEST(HiddenPropertiesLeakage) {
+ i::FLAG_harmony_object_observe = true;
HandleScope scope(CcTest::isolate());
LocalContext context(CcTest::isolate());
CompileRun("var obj = {};"
@@ -697,6 +718,7 @@ TEST(HiddenPropertiesLeakage) {
TEST(GetNotifierFromOtherContext) {
+ i::FLAG_harmony_object_observe = true;
HandleScope scope(CcTest::isolate());
LocalContext context(CcTest::isolate());
CompileRun("var obj = {};");
@@ -713,6 +735,7 @@ TEST(GetNotifierFromOtherContext) {
TEST(GetNotifierFromOtherOrigin) {
+ i::FLAG_harmony_object_observe = true;
HandleScope scope(CcTest::isolate());
Local<Value> foo = v8_str("foo");
Local<Value> bar = v8_str("bar");
@@ -733,6 +756,7 @@ TEST(GetNotifierFromOtherOrigin) {
TEST(GetNotifierFromSameOrigin) {
+ i::FLAG_harmony_object_observe = true;
HandleScope scope(CcTest::isolate());
Local<Value> foo = v8_str("foo");
LocalContext context(CcTest::isolate());
@@ -784,6 +808,7 @@ static void CheckSurvivingGlobalObjectsCount(int expected) {
TEST(DontLeakContextOnObserve) {
+ i::FLAG_harmony_object_observe = true;
HandleScope scope(CcTest::isolate());
Local<Value> foo = v8_str("foo");
LocalContext context(CcTest::isolate());
@@ -809,6 +834,7 @@ TEST(DontLeakContextOnObserve) {
TEST(DontLeakContextOnGetNotifier) {
+ i::FLAG_harmony_object_observe = true;
HandleScope scope(CcTest::isolate());
Local<Value> foo = v8_str("foo");
LocalContext context(CcTest::isolate());
@@ -832,6 +858,7 @@ TEST(DontLeakContextOnGetNotifier) {
TEST(DontLeakContextOnNotifierPerformChange) {
+ i::FLAG_harmony_object_observe = true;
HandleScope scope(CcTest::isolate());
Local<Value> foo = v8_str("foo");
LocalContext context(CcTest::isolate());
@@ -869,6 +896,7 @@ static void ObserverCallback(const FunctionCallbackInfo<Value>& args) {
TEST(ObjectObserveCallsCppFunction) {
+ i::FLAG_harmony_object_observe = true;
Isolate* isolate = CcTest::isolate();
HandleScope scope(isolate);
LocalContext context(isolate);
@@ -891,6 +919,7 @@ TEST(ObjectObserveCallsCppFunction) {
TEST(ObjectObserveCallsFunctionTemplateInstance) {
+ i::FLAG_harmony_object_observe = true;
Isolate* isolate = CcTest::isolate();
HandleScope scope(isolate);
LocalContext context(isolate);
@@ -926,6 +955,7 @@ static void AccessorSetter(Local<Name> property, Local<Value> value,
TEST(APIAccessorsShouldNotNotify) {
+ i::FLAG_harmony_object_observe = true;
Isolate* isolate = CcTest::isolate();
HandleScope handle_scope(isolate);
LocalContext context(isolate);
@@ -959,6 +989,7 @@ void MockUseCounterCallback(v8::Isolate* isolate,
TEST(UseCountObjectObserve) {
+ i::FLAG_harmony_object_observe = true;
i::Isolate* isolate = CcTest::i_isolate();
i::HandleScope scope(isolate);
LocalContext env;
@@ -986,6 +1017,7 @@ TEST(UseCountObjectObserve) {
TEST(UseCountObjectGetNotifier) {
+ i::FLAG_harmony_object_observe = true;
i::Isolate* isolate = CcTest::i_isolate();
i::HandleScope scope(isolate);
LocalContext env;
@@ -1005,6 +1037,7 @@ static bool NamedAccessCheckAlwaysAllow(Local<v8::Context> accessing_context,
TEST(DisallowObserveAccessCheckedObject) {
+ i::FLAG_harmony_object_observe = true;
v8::Isolate* isolate = CcTest::isolate();
v8::HandleScope scope(isolate);
LocalContext env;
@@ -1026,6 +1059,7 @@ TEST(DisallowObserveAccessCheckedObject) {
TEST(DisallowGetNotifierAccessCheckedObject) {
+ i::FLAG_harmony_object_observe = true;
v8::Isolate* isolate = CcTest::isolate();
v8::HandleScope scope(isolate);
LocalContext env;
« no previous file with comments | « test/cctest/test-microtask-delivery.cc ('k') | test/mjsunit/es7/regress/regress-443982.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698