Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 1511293002: Pass --harmony-object-observe in tests that depend on it (Closed)

Created:
5 years ago by adamk
Modified:
5 years ago
Reviewers:
Dan Ehrenberg
CC:
Jakob Kummerow, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Pass --harmony-object-observe in tests that depend on it This is in preparation for turning the flag off by default. BUG=chromium:552100 LOG=n Committed: https://crrev.com/2f9c68cfb102f4affe4567802fd0033f06c21f3a Cr-Commit-Position: refs/heads/master@{#32729}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -1 line) Patch
M test/cctest/test-api.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M test/cctest/test-debug.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-microtask-delivery.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M test/cctest/test-object-observe.cc View 34 chunks +34 lines, -0 lines 0 comments Download
M test/mjsunit/es7/regress/regress-443982.js View 1 chunk +2 lines, -0 lines 0 comments Download
M test/mjsunit/regress/regress-417709b.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
adamk
I tested locally by turning the flag off and waited for failures.
5 years ago (2015-12-09 20:12:19 UTC) #2
Dan Ehrenberg
lgtm LGTM, but seems like something else will be needed for LayoutTests using Object.observe
5 years ago (2015-12-09 20:20:19 UTC) #3
adamk
On 2015/12/09 20:20:19, Dan Ehrenberg wrote: > lgtm > > LGTM, but seems like something ...
5 years ago (2015-12-09 20:22:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1511293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1511293002/1
5 years ago (2015-12-09 20:23:25 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-09 20:33:30 UTC) #7
commit-bot: I haz the power
5 years ago (2015-12-09 20:34:25 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2f9c68cfb102f4affe4567802fd0033f06c21f3a
Cr-Commit-Position: refs/heads/master@{#32729}

Powered by Google App Engine
This is Rietveld 408576698