Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 1511203002: tools/gn: depend on allocator_extension.cc to keep bootstrap working (Closed)

Created:
5 years ago by tfarina
Modified:
5 years ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews, tfarina, Dirk Pranke, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

tools/gn: depend on allocator_extension.cc to keep bootstrap working This patch adds the missing base/allocator/allocator_extension.cc to the sources list to keep the boostrap process working and to fix the undefined reference error as below: malloc_dump_provider.cc:(.text+0x92): undefined reference to `base::allocator::GetNumericProperty(char const*, unsigned long*)' BUG=None TEST=./tools/gn/bootstrap/bootstrap.py TBR=brettw@chromium.org Committed: https://crrev.com/22d5facb2fef65c3085477319a96eeadf3650d3f Cr-Commit-Position: refs/heads/master@{#364053}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tools/gn/bootstrap/bootstrap.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
tfarina
TBRing...
5 years ago (2015-12-09 13:12:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1511203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1511203002/1
5 years ago (2015-12-09 13:13:50 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-09 13:24:18 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/22d5facb2fef65c3085477319a96eeadf3650d3f Cr-Commit-Position: refs/heads/master@{#364053}
5 years ago (2015-12-09 13:25:24 UTC) #6
Dirk Pranke
5 years ago (2015-12-09 16:47:47 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698