Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 1511183004: Provide pdf_enable_xfa GN variable on master, too. (Closed)

Created:
5 years ago by Tom Sepez
Modified:
5 years ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Provide pdf_enable_xfa GN variable on master, too. That way, pdf/BUILD.gn can test it no matter which branch of PDFium is pulled under a chrome checkout. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/e5d275f39ab7651077d31b3ae76b75391f397da0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M pdfium.gni View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Tom Sepez
Lei, for review.
5 years ago (2015-12-09 21:18:10 UTC) #2
Lei Zhang
lgtm
5 years ago (2015-12-09 22:05:21 UTC) #3
Tom Sepez
5 years ago (2015-12-09 22:23:36 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e5d275f39ab7651077d31b3ae76b75391f397da0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698