Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 1511183002: Revert of default SkPixelSerializer (Closed)

Created:
5 years ago by hal.canary
Modified:
5 years ago
Reviewers:
scroggo, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of default SkPixelSerializer (patchset #2 id:20001 of https://codereview.chromium.org/1507123002/ ) Reason for revert: I was overconfident. Original issue's description: > default SkPixelSerializer > > Add SkImageEncoder::EncodeData(const SkPixmap&, ...) function. > > Add SkImageEncoder::CreatePixelSerializer() to return a > PixelSerializer that calls into SkImageEncoder::EncodeData. > > SkImage::encode() make use of SkImageEncoder::CreatePixelSerializer. > > Committed: https://skia.googlesource.com/skia/+/b0bd1516bff3f5afcbfd615e805867531657811b > > Committed: https://skia.googlesource.com/skia/+/808ce2886d732b1055f89c8fb0f1b11b47fcb0ce TBR=reed@google.com,scroggo@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/a2e056773da8b029c9dccd5be265cb43615786c7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -70 lines) Patch
M debugger/QT/SkDebuggerGUI.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M include/core/SkImageEncoder.h View 2 chunks +0 lines, -8 lines 0 comments Download
M src/image/SkImage.cpp View 2 chunks +25 lines, -8 lines 0 comments Download
M src/images/SkImageEncoder.cpp View 2 chunks +2 lines, -31 lines 0 comments Download
M src/ports/SkImageDecoder_empty.cpp View 2 chunks +0 lines, -17 lines 0 comments Download
M tests/PictureTest.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M tools/sk_tool_utils.h View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
hal.canary
Created Revert of default SkPixelSerializer
5 years ago (2015-12-09 11:55:51 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1511183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1511183002/1
5 years ago (2015-12-09 11:55:54 UTC) #2
commit-bot: I haz the power
5 years ago (2015-12-09 11:56:05 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/a2e056773da8b029c9dccd5be265cb43615786c7

Powered by Google App Engine
This is Rietveld 408576698