Remove SK_SUPPORT_LEGACY_HQ_DOWNSAMPLING

Remove SK_SUPPORT_LEGACY_HQ_DOWNSAMPLING

Switches Skia's software HQ downscaling algorithm from Mitchell to
mipmaps.

This is a good idea because

1) it aligns the results with Ganesh (which already uses
  mipmaps for downscaling)

2) mipmaps are cheaper/more efficient (to produce and to cache)

3) yields (arguably) sharper results, particularly when scaling to
  half size - which appears to be a common technique used for
  Retina-ready pages.

BUG=583478, 562162
R=reed@google.com,senorblanco@chromium.org

Committed: https://crrev.com/0c7e2f7bcee59d0f26ed86a0d87dce4e0800f2f2
Cr-Commit-Position: refs/heads/master@{#374703}

[f(malita), 2016-02-09 22:41:39]

Description was changed from

==========
Remove SK_SUPPORT_LEGACY_HQ_DOWNSAMPLING

This switches to using mipmaps for bitmap downscaling (instead of
current Mitchell).

BUG=
==========

to

==========
Remove SK_SUPPORT_LEGACY_HQ_DOWNSAMPLING

Switches Skia's software HQ downscaling algorithm from Mitchell to
mipmaps.

This is a good idea because

1) it aligns the results with Ganesh (which already uses
  mipmaps for downscaling)

2) is cheaper/more efficient

3) produces (arguably) sharper results, particularly when scaling to
  half size - which appears to be a common technique used for
  Retina-ready pages.


BUG=583478,562162
R=reed@google.com,senorblanco@chromium.org
==========

[f(malita), 2016-02-09 22:46:28]

Description was changed from

==========
Remove SK_SUPPORT_LEGACY_HQ_DOWNSAMPLING

Switches Skia's software HQ downscaling algorithm from Mitchell to
mipmaps.

This is a good idea because

1) it aligns the results with Ganesh (which already uses
  mipmaps for downscaling)

2) is cheaper/more efficient

3) produces (arguably) sharper results, particularly when scaling to
  half size - which appears to be a common technique used for
  Retina-ready pages.


BUG=583478,562162
R=reed@google.com,senorblanco@chromium.org
==========

to

==========
Remove SK_SUPPORT_LEGACY_HQ_DOWNSAMPLING

Switches Skia's software HQ downscaling algorithm from Mitchell to
mipmaps.

This is a good idea because

1) it aligns the results with Ganesh (which already uses
  mipmaps for downscaling)

2) mipmaps are cheaper/more efficient (to produce and to cache)

3) yields (arguably) sharper results, particularly when scaling to
  half size - which appears to be a common technique used for
  Retina-ready pages.


BUG=583478,562162
R=reed@google.com,senorblanco@chromium.org
==========

[f(malita), 2016-02-09 22:52:15]

fmalita@chromium.org changed reviewers:
+ reed@google.com, senorblanco@chromium.org

[f(malita), 2016-02-09 22:52:16]

~220 rebaselines, mostly trivial.

Some interesting diffs with contrast improvements:

https://storage.googleapis.com/chromium-layout-test-archives/linux_blink_rel/...
https://storage.googleapis.com/chromium-layout-test-archives/linux_blink_rel/...
https://storage.googleapis.com/chromium-layout-test-archives/linux_blink_rel/...
https://storage.googleapis.com/chromium-layout-test-archives/linux_blink_rel/...
https://storage.googleapis.com/chromium-layout-test-archives/linux_blink_rel/...

[f(malita), 2016-02-09 23:01:24]

On 2016/02/09 22:52:16, f(malita) wrote:
> ~220 rebaselines, mostly trivial.
> 
> Some interesting diffs with contrast improvements:
> 
>
https://storage.googleapis.com/chromium-layout-test-archives/linux_blink_rel/...
>
https://storage.googleapis.com/chromium-layout-test-archives/linux_blink_rel/...
>
https://storage.googleapis.com/chromium-layout-test-archives/linux_blink_rel/...
>
https://storage.googleapis.com/chromium-layout-test-archives/linux_blink_rel/...
>
https://storage.googleapis.com/chromium-layout-test-archives/linux_blink_rel/...

Forgot to post the full layout test results:
https://storage.googleapis.com/chromium-layout-test-archives/linux_blink_rel/...

[reed1, 2016-02-10 14:47:34]

lgtm

[Stephen White, 2016-02-10 15:09:24]

senorblanco@chromium.org changed reviewers:
+ junov@chromium.org

[Stephen White, 2016-02-10 15:09:59]

LGTM \o/

FYI +junov since this affects <canvas> also.

[Justin Novosad, 2016-02-10 15:17:25]

On 2016/02/10 15:09:59, Stephen White wrote:
> LGTM \o/
> 
> FYI +junov since this affects <canvas> also.

It only might affects the currently-not-shipped imageSmoothingQuality feature.
So lgtm.

[f(malita), 2016-02-10 15:21:19]

The CQ bit was checked by fmalita@chromium.org

[commit-bot: I haz the power, 2016-02-10 15:23:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1511113004/240001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1511113004/240001

[commit-bot: I haz the power, 2016-02-10 16:43:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-10 16:43:32]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[f(malita), 2016-02-10 16:44:42]

The CQ bit was checked by fmalita@chromium.org

[commit-bot: I haz the power, 2016-02-10 16:45:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1511113004/240001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1511113004/240001

[commit-bot: I haz the power, 2016-02-10 16:52:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-10 16:52:37]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[f(malita), 2016-02-10 16:53:57]

The CQ bit was checked by fmalita@chromium.org

[commit-bot: I haz the power, 2016-02-10 16:54:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1511113004/240001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1511113004/240001

[commit-bot: I haz the power, 2016-02-10 19:42:35]

Description was changed from

==========
Remove SK_SUPPORT_LEGACY_HQ_DOWNSAMPLING

Switches Skia's software HQ downscaling algorithm from Mitchell to
mipmaps.

This is a good idea because

1) it aligns the results with Ganesh (which already uses
  mipmaps for downscaling)

2) mipmaps are cheaper/more efficient (to produce and to cache)

3) yields (arguably) sharper results, particularly when scaling to
  half size - which appears to be a common technique used for
  Retina-ready pages.


BUG=583478,562162
R=reed@google.com,senorblanco@chromium.org
==========

to

==========
Remove SK_SUPPORT_LEGACY_HQ_DOWNSAMPLING

Switches Skia's software HQ downscaling algorithm from Mitchell to
mipmaps.

This is a good idea because

1) it aligns the results with Ganesh (which already uses
  mipmaps for downscaling)

2) mipmaps are cheaper/more efficient (to produce and to cache)

3) yields (arguably) sharper results, particularly when scaling to
  half size - which appears to be a common technique used for
  Retina-ready pages.


BUG=583478,562162
R=reed@google.com,senorblanco@chromium.org
==========

[commit-bot: I haz the power, 2016-02-10 19:42:36]

Committed patchset #13 (id:240001)

[commit-bot: I haz the power, 2016-02-16 22:30:31]

Description was changed from

==========
Remove SK_SUPPORT_LEGACY_HQ_DOWNSAMPLING

Switches Skia's software HQ downscaling algorithm from Mitchell to
mipmaps.

This is a good idea because

1) it aligns the results with Ganesh (which already uses
  mipmaps for downscaling)

2) mipmaps are cheaper/more efficient (to produce and to cache)

3) yields (arguably) sharper results, particularly when scaling to
  half size - which appears to be a common technique used for
  Retina-ready pages.


BUG=583478,562162
R=reed@google.com,senorblanco@chromium.org
==========

to

==========
Remove SK_SUPPORT_LEGACY_HQ_DOWNSAMPLING

Switches Skia's software HQ downscaling algorithm from Mitchell to
mipmaps.

This is a good idea because

1) it aligns the results with Ganesh (which already uses
  mipmaps for downscaling)

2) mipmaps are cheaper/more efficient (to produce and to cache)

3) yields (arguably) sharper results, particularly when scaling to
  half size - which appears to be a common technique used for
  Retina-ready pages.

BUG=583478,562162
R=reed@google.com,senorblanco@chromium.org

Committed: https://crrev.com/0c7e2f7bcee59d0f26ed86a0d87dce4e0800f2f2
Cr-Commit-Position: refs/heads/master@{#374703}
==========

[commit-bot: I haz the power, 2016-02-16 22:30:32]

Patchset 13 (id:??) landed as
https://crrev.com/0c7e2f7bcee59d0f26ed86a0d87dce4e0800f2f2
Cr-Commit-Position: refs/heads/master@{#374703}