extensions/common/test_util.h - Issue 1511103003: Use rvalue reference instead of ExtensionBuilder::pass()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/test_util.h

Issue 1511103003: Use rvalue reference instead of ExtensionBuilder::pass() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nit change(dana review) Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/common/test_util.h

diff --git a/extensions/common/test_util.h b/extensions/common/test_util.h

index 0f02ac0e54be57e62523b58f54a005f6e5be7efd..722039944191e292c03130381af6d8a4faa3a205 100644

--- a/extensions/common/test_util.h

+++ b/extensions/common/test_util.h

@@ -16,10 +16,10 @@ class ExtensionBuilder;

namespace test_util {

// Adds an extension manifest to a builder.

-ExtensionBuilder& BuildExtension(ExtensionBuilder& builder);

+ExtensionBuilder BuildExtension(ExtensionBuilder builder);

// Adds an app manifest to a builder.

-ExtensionBuilder& BuildApp(ExtensionBuilder& builder);

+ExtensionBuilder BuildApp(ExtensionBuilder builder);

// Creates an extension instance that can be attached to an ExtensionFunction

// before running it.

« no previous file with comments | « extensions/common/extension_builder.cc ('k') | extensions/common/test_util.cc » ('j') | no next file with comments »