Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: chrome/common/extensions/api/common_extension_api_unittest.cc

Issue 1511103003: Use rvalue reference instead of ExtensionBuilder::pass() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/api/common_extension_api_unittest.cc
diff --git a/chrome/common/extensions/api/common_extension_api_unittest.cc b/chrome/common/extensions/api/common_extension_api_unittest.cc
index d306d80f268bdaab2c2c28721139e7ca956ee6fb..47d89e67dd2439d7add81d235336235ea4a2e5c0 100644
--- a/chrome/common/extensions/api/common_extension_api_unittest.cc
+++ b/chrome/common/extensions/api/common_extension_api_unittest.cc
@@ -807,7 +807,7 @@ TEST(ExtensionAPITest, NoPermissions) {
scoped_ptr<ExtensionAPI> extension_api(
ExtensionAPI::CreateWithDefaultConfiguration());
scoped_refptr<Extension> extension =
- BuildExtension(ExtensionBuilder().Pass()).Build();
+ BuildExtension(ExtensionBuilder()).Build();
for (size_t i = 0; i < arraysize(kTests); ++i) {
EXPECT_EQ(kTests[i].expect_success,
@@ -826,10 +826,10 @@ TEST(ExtensionAPITest, ManifestKeys) {
ExtensionAPI::CreateWithDefaultConfiguration());
scoped_refptr<Extension> extension =
- BuildExtension(ExtensionBuilder().Pass())
- .MergeManifest(DictionaryBuilder().Set("browser_action",
- DictionaryBuilder().Pass()))
- .Build();
+ BuildExtension(ExtensionBuilder())
+ .MergeManifest(DictionaryBuilder().Set("browser_action",
+ DictionaryBuilder().Pass()))
+ .Build();
EXPECT_TRUE(extension_api->IsAvailable("browserAction",
extension.get(),

Powered by Google App Engine
This is Rietveld 408576698