Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Side by Side Diff: extensions/common/test_util.h

Issue 1511103003: Use rvalue reference instead of ExtensionBuilder::pass() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nit change(dana review) Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « extensions/common/extension_builder.cc ('k') | extensions/common/test_util.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef EXTENSIONS_COMMON_TEST_UTIL_H_ 5 #ifndef EXTENSIONS_COMMON_TEST_UTIL_H_
6 #define EXTENSIONS_COMMON_TEST_UTIL_H_ 6 #define EXTENSIONS_COMMON_TEST_UTIL_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/memory/ref_counted.h" 10 #include "base/memory/ref_counted.h"
11 11
12 namespace extensions { 12 namespace extensions {
13 class Extension; 13 class Extension;
14 class ExtensionBuilder; 14 class ExtensionBuilder;
15 15
16 namespace test_util { 16 namespace test_util {
17 17
18 // Adds an extension manifest to a builder. 18 // Adds an extension manifest to a builder.
19 ExtensionBuilder& BuildExtension(ExtensionBuilder& builder); 19 ExtensionBuilder BuildExtension(ExtensionBuilder builder);
20 20
21 // Adds an app manifest to a builder. 21 // Adds an app manifest to a builder.
22 ExtensionBuilder& BuildApp(ExtensionBuilder& builder); 22 ExtensionBuilder BuildApp(ExtensionBuilder builder);
23 23
24 // Creates an extension instance that can be attached to an ExtensionFunction 24 // Creates an extension instance that can be attached to an ExtensionFunction
25 // before running it. 25 // before running it.
26 scoped_refptr<Extension> CreateEmptyExtension(); 26 scoped_refptr<Extension> CreateEmptyExtension();
27 27
28 // Create an extension with a variable |id|, for tests that require multiple 28 // Create an extension with a variable |id|, for tests that require multiple
29 // extensions side-by-side having distinct IDs. 29 // extensions side-by-side having distinct IDs.
30 scoped_refptr<Extension> CreateEmptyExtension(const std::string& id); 30 scoped_refptr<Extension> CreateEmptyExtension(const std::string& id);
31 31
32 } // namespace test_util 32 } // namespace test_util
33 } // namespace extensions 33 } // namespace extensions
34 34
35 #endif // EXTENSIONS_COMMON_TEST_UTIL_H_ 35 #endif // EXTENSIONS_COMMON_TEST_UTIL_H_
OLDNEW
« no previous file with comments | « extensions/common/extension_builder.cc ('k') | extensions/common/test_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698