Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 151110: Fix download page (Closed)

Created:
11 years, 5 months ago by jcampan
Modified:
9 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google), tim (not reviewing)
Visibility:
Public.

Description

A recent refactoring of the DOM UI had caused the download page to be blank. A call to Init had been removed. BUG=http://crbug.com/15680 TEST=Download a file. Open the download page (CTRL-J) it should show the download. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19681

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/dom_ui/downloads_ui.cc View 1 chunk +1 line, -0 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
jcampan
Brett, I am sending this review your way as I believe Tim is not available ...
11 years, 5 months ago (2009-06-30 20:55:43 UTC) #1
brettw
11 years, 5 months ago (2009-06-30 22:29:38 UTC) #2
LGTM

http://codereview.chromium.org/151110/diff/1/2
File chrome/browser/dom_ui/downloads_ui.cc (right):

http://codereview.chromium.org/151110/diff/1/2#newcode127
Line 127: handler->Init();
I noticed it had been removed actually, and I'm like "hey, he made it so you
don't have to call init anymore, great".

Powered by Google App Engine
This is Rietveld 408576698