Issue 151110: Fix download page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 151110: Fix download page (Closed)

Created:
11 years, 5 months ago by jcampan

Modified:
9 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google), tim (not reviewing)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

A recent refactoring of the DOM UI had caused the download page to be blank. A call to Init had been removed. BUG=http://crbug.com/15680 TEST=Download a file. Open the download page (CTRL-J) it should show the download. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19681

Patch Set 1 #

Total comments: 1

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	chrome/browser/dom_ui/downloads_ui.cc	View		1 chunk	+1 line, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jcampan

Brett, I am sending this review your way as I believe Tim is not available ...

11 years, 5 months ago (2009-06-30 20:55:43 UTC) #1

brettw

11 years, 5 months ago (2009-06-30 22:29:38 UTC) #2

LGTM

http://codereview.chromium.org/151110/diff/1/2
File chrome/browser/dom_ui/downloads_ui.cc (right):

http://codereview.chromium.org/151110/diff/1/2#newcode127
Line 127: handler->Init();
I noticed it had been removed actually, and I'm like "hey, he made it so you
don't have to call init anymore, great".

Expand Messages | Collapse Messages