Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 151103010: Revert of android: Migrate old content readback to use async readback (and delegated renderer) (Closed)

Created:
6 years, 10 months ago by powei
Modified:
6 years, 10 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, James Su, miu+watch_chromium.org, no sievers
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revert of android: Migrate old content readback to use async readback (and delegated renderer) (https://codereview.chromium.org/143803004/) Reason for revert: broke android build Original issue's description: > android: Migrate old content readback to use async readback (and delegated renderer) > > This patch removes the use of a helper context for content readback. Instead, > we use the async readback API. > > This patch is also setting delegated renderer as the default for android. > > android= https://chrome-internal-review.googlesource.com/#/c/153667/ > > BUG=326363 > TBR=sievers > NOTRY=true > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248827 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=249081 TBR=dtrainor@chromium.org,aelias@chromium.org NOTREECHECKS=true NOTRY=true BUG=326363 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=249175

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+246 lines, -204 lines) Patch
M cc/resources/ui_resource_bitmap.h View 1 chunk +1 line, -2 lines 0 comments Download
M cc/resources/ui_resource_bitmap.cc View 2 chunks +7 lines, -10 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M content/browser/android/content_startup_flags.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/android/content_view_core_impl.h View 1 chunk +2 lines, -4 lines 0 comments Download
M content/browser/android/content_view_core_impl.cc View 1 chunk +6 lines, -9 lines 0 comments Download
M content/browser/renderer_host/compositor_impl_android.h View 4 chunks +17 lines, -12 lines 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 4 chunks +122 lines, -86 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.h View 2 chunks +6 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 13 chunks +52 lines, -46 lines 0 comments Download
M content/public/browser/android/compositor.h View 2 chunks +29 lines, -12 lines 0 comments Download
M content/public/browser/android/content_view_core.h View 2 chunks +2 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
powei
Created Revert of android: Migrate old content readback to use async readback (and delegated renderer)
6 years, 10 months ago (2014-02-06 00:04:11 UTC) #1
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-06 00:08:58 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 10 months ago (2014-02-06 00:08:58 UTC) #3
Yusuf
lgtm
6 years, 10 months ago (2014-02-06 00:11:55 UTC) #4
powei
The CQ bit was checked by powei@chromium.org
6 years, 10 months ago (2014-02-06 00:13:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/powei@chromium.org/151103010/1
6 years, 10 months ago (2014-02-06 00:15:54 UTC) #6
commit-bot: I haz the power
6 years, 10 months ago (2014-02-06 00:22:06 UTC) #7
Message was sent while issue was closed.
Change committed as 249175

Powered by Google App Engine
This is Rietveld 408576698