Issue 151103006: Tests for (pre)parse errors when "yield" is found in inappropriate places.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 151103006: Tests for (pre)parse errors when "yield" is found in inappropriate places. (Closed)

Created:
6 years, 10 months ago by marja

Modified:
6 years, 10 months ago

Reviewers:
ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Tests for (pre)parse errors when "yield" is found in inappropriate places. In addition: - Fix: PreParser used to report an unexpected token one token too late when ParsePrimaryExpression failed. - Unified identifier handling (PreParser::GetIdentifier is now like Parser::GetIdentifier). - Fix: PreParser used to produce "unexpected_token YIELD" errors when Parser produced "unexpected_token_identifier"; fixed PreParser to match Parser. BUG=3126 LOG=N R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19082

Patch Set 1 #

Patch Set 2 : whitespace #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+77 lines, -30 lines)			Patch
	M	src/preparser.cc	View	1	3 chunks	+12 lines, -30 lines	0 comments	Download
	M	test/cctest/test-parsing.cc	View		1 chunk	+65 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

marja

6 years, 10 months ago (2014-02-04 18:16:52 UTC) #2

Message was sent while issue was closed.

Committed patchset #2 manually as r19082 (presubmit successful).

Expand Messages | Collapse Messages